Make Converter passing explicit #3171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -45,8 +45,8 @@ import { Provider, ComponentContainer } from '@firebase/component'; | |||
| */ | |||
| export const FIRESTORE = new Firestore( | |||
| { | |||
| projectId: 'projectid', | |||
| database: 'database' | |||
| projectId: 'test-project', | |||
There was a problem hiding this comment.
Changed so I can get rid of fakeFirestore.
Binary Size ReportAffected SDKs
Test Logs
|
thebrianchen
approved these changes
Jun 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the comments in the Transaction PR was about a missing converter argument. This PR should make these problems go away by no longer allowing
undefined.I also stumbled across a test Firestore that I can use instead of
fakeFirestore.