Skip to content

Check for converter in Query.isEqual() #3181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2020
Merged

Conversation

thebrianchen
Copy link

@thebrianchen thebrianchen commented Jun 7, 2020

We have been checking the converter when performing equality checks in DocumentReference, but not for Query and CollectionReference. This PR standardizes all classes that contain converters to check for them when making equality checks.

Also, @schmidt-sebastian, wouldn't this be considered a breaking change?

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (0fac7bd) Head (7a6619d) Diff
    browser 252 kB 252 kB +16 B (+0.0%)
    esm2017 195 kB 195 kB +16 B (+0.0%)
    main 494 kB 494 kB +36 B (+0.0%)
    module 249 kB 249 kB +16 B (+0.0%)
  • @firebase/firestore/memory

    Type Base (0fac7bd) Head (7a6619d) Diff
    browser 192 kB 192 kB +16 B (+0.0%)
    esm2017 149 kB 149 kB +16 B (+0.0%)
    main 370 kB 370 kB +36 B (+0.0%)
    module 190 kB 190 kB +16 B (+0.0%)
  • firebase

    Type Base (0fac7bd) Head (7a6619d) Diff
    firebase-firestore.js 290 kB 290 kB +16 B (+0.0%)
    firebase-firestore.memory.js 232 kB 232 kB +16 B (+0.0%)
    firebase.js 823 kB 823 kB +16 B (+0.0%)

Test Logs

Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This is technically breaking but below the threshold where I would worry about it. Let's see if I get proven wrong.

@thebrianchen thebrianchen merged commit df36a24 into master Jun 7, 2020
@thebrianchen thebrianchen deleted the bc/check-conv branch June 7, 2020 22:26
@firebase firebase locked and limited conversation to collaborators Jul 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants