Skip to content

Add missing changelog for #3184 #3187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 8, 2020
Merged

Add missing changelog for #3184 #3187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
755c901
Refetch token if attempt was invalidated
schmidt-sebastian Jun 7, 2020
957a2ed
Changelog
schmidt-sebastian Jun 8, 2020
a2599d6
Update CHANGELOG.md
schmidt-sebastian Jun 8, 2020
079494c
Update CHANGELOG.md
schmidt-sebastian Jun 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/firestore/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
# Unreleased
- [fixed] Fixed an issue that may have prevented the client from connecting
to the backend immediately after a user signed in.

# Released
- [changed] All known failure cases for Indexed-related crashes have now been
addressed. Instead of crashing the client, IndexedDB failures will result
in rejected operations (e.g. rejected Writes or errored Query listeners).
Expand All @@ -9,8 +13,6 @@

If you continue to see Indexed-related crashes, we appreciate feedback
(https://github.com/firebase/firebase-js-sdk/issues/2755).

# Released
- [fixed] Fixed an issue that could cause Firestore to temporarily go
offline when a Window visibility event occurred.
- [feature] Added support for calling `FirebaseFiresore.settings` with
Expand Down
6 changes: 4 additions & 2 deletions packages/firestore/src/api/credentials.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import {
FirebaseAuthInternalName
} from '@firebase/auth-interop-types';
import { Provider } from '@firebase/component';
import { logDebug } from '../util/log';

// TODO(mikelehen): This should be split into multiple files and probably
// moved to an auth/ folder to match other platforms.
Expand Down Expand Up @@ -214,10 +215,11 @@ export class FirebaseCredentialsProvider implements CredentialsProvider {
// outstanding so the response is potentially for a previous user (which
// user, we can't be sure).
if (this.tokenCounter !== initialTokenCounter) {
throw new FirestoreError(
Code.ABORTED,
logDebug(
'FirebaseCredentialsProvider',
'getToken aborted due to token change.'
);
return this.getToken();
} else {
if (tokenData) {
hardAssert(
Expand Down