Add GPMID header to Firebase Database #3190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary Size ReportAffected SDKs
Test Logs
|
jsdt
approved these changes
Jun 10, 2020
Feiyang1
reviewed
Jun 17, 2020
| @@ -1,4 +1,5 @@ | |||
| # Unreleased | |||
| - [changed] Added internal HTTP header to the WebChannel connection. | |||
There was a problem hiding this comment.
I don't think database uses WebChannel? or are you using it as a general term for realtime connection?
There was a problem hiding this comment.
WebSockets. Will fix.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of https://github.com/firebase/firebase-android-sdk/pull/1610/files