Tree-Shakeable Serialization #3231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary Size ReportAffected SDKs
Test Logs
|
schmidt-sebastian
force-pushed
the
mrschmidt/serializer
branch
3 times, most recently
from
c449195 to
458cdf8
Compare
wilhuff
reviewed
Jun 18, 2020
| @@ -93,10 +93,14 @@ export class Firestore implements firestore.FirebaseFirestore { | |||
| this._datastorePromise = PlatformSupport.getPlatform() | |||
| .loadConnection(databaseInfo) | |||
| .then(connection => { | |||
| const serializer = PlatformSupport.getPlatform().newSerializer( | |||
| const serializationOptions = PlatformSupport.getPlatform().newSerializationOptions( | |||
There was a problem hiding this comment.
In tree-shakeable style, the structure containing the data we pass through that used to be a class is now just a dumb struct, but it still has the same identity. All that's changed is that it's a dumb struct with accompanying functions instead of a class with member functions.
For parity with the other platforms I think it still makes sense to call that thing a Serializer.
There was a problem hiding this comment.
The parity argument makes sense. I updated the PR accordingly.
schmidt-sebastian
force-pushed
the
mrschmidt/serializer
branch
from
458cdf8 to
9c4663a
Compare
wu-hui
approved these changes
Jun 19, 2020
| * Returns a number (or null) from a google.protobuf.Int32Value proto. | ||
| */ | ||
| function fromInt32Proto( | ||
| serializer: JsonProtoSerializer, |
There was a problem hiding this comment.
serializer is not needed here.
There was a problem hiding this comment.
Fixed (also in a couple other places)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the class methods in JSONSerializer with free standing functions, which allows for a lot of tree shaking (see binary size report).
This PR is split in three parts:
005abb3is a manual change that uses an options interface in lieu of the empty serializer class.This PR is a bit easier to review by appending "?w=1" to the URL.