Skip to content

Remove gRPC and protos from @firebase/testing #3236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 19, 2020
Merged

Conversation

samtstern
Copy link
Contributor

Removes the protos and @grpc/grpc-js from @firebase/testing and replaces it with simple REST calls.

Also fun fact: this module never actually listed grpc-js as a dependency so we were just lucky.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 18, 2020

Binary Size Report

Affected SDKs

  • @firebase/testing

    Type Base (246ed9d) Head (791fcbe) Diff
    main 6.67 kB 6.34 kB -331 B (-5.0%)

Test Logs

@samtstern samtstern requested a review from yuchenshi June 19, 2020 17:17
@samtstern
Copy link
Contributor Author

@firebase/messaging: npm ERR! code ELIFECYCLE
@firebase/messaging: npm ERR! errno 1
@firebase/messaging: npm ERR! [email protected] test: `mocha --exit`
@firebase/messaging: npm ERR! Exit status 1
@firebase/messaging: npm ERR! 
@firebase/messaging: npm ERR! Failed at the [email protected] test script.
@firebase/messaging: npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
@firebase/messaging: npm ERR! A complete log of this run can be found in:
@firebase/messaging: npm ERR!     /home/runner/.npm/_logs/2020-06-19T17_43_30_344Z-debug.log

These keep getting in my way.

@yuchenshi yuchenshi assigned samtstern and unassigned yuchenshi Jun 19, 2020
@yuchenshi
Copy link
Member

Please keep trying -- I doubt it's related. It might be just flaky tests. If this keep happening let's pull in some folks who might be familiar with it.

@samtstern samtstern merged commit d525b69 into master Jun 19, 2020
@firebase firebase locked and limited conversation to collaborators Jul 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants