Big refactor of reauth / link + basic idp tasks #3242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary Size ReportAffected SDKs
Test Logs
|
avolkovi
reviewed
Jun 23, 2020
| }; | ||
| } | ||
|
|
||
| export async function _signIn(params: IdpTaskParams): Promise<UserCredential> { |
| @@ -46,4 +48,10 @@ export class UserCredentialImpl implements UserCredential { | |||
| // updateAdditionalUserInfoFromIdTokenResponse(userCred, idTokenResponse); | |||
| return userCred; | |||
| } | |||
|
|
|||
| static async _forOperation(user: User, operationType: externs.OperationType, response: PhoneOrOauthTokenResponse): Promise<UserCredentialImpl> { | |||
There was a problem hiding this comment.
should we also use this for SIGN_IN?
There was a problem hiding this comment.
Let me clean this up in a separate PR. The credential param in _fromIdTokenResponse shouldn't be set as the credential field in the UserCredential object. Instead, it is just used to determine "isAnonymous". I will consolidate all of this into one method later
| const response = await signInWithIdp(auth, request); | ||
|
|
||
| const credential = _authCredentialFromTokenResponse(response); | ||
| const userCredential = await UserCredentialImpl._fromIdTokenResponse( |
There was a problem hiding this comment.
why not use _forOperation here? then you can fold the logic for _authCredentialFromTokenResponse and only have it used in one place
There was a problem hiding this comment.
One thing too is that _forOperation doesn't init a user object, which we do need for sign in.
avolkovi
approved these changes
Jun 24, 2020
|
Didn't mean to close it -_- |
avolkovi
pushed a commit
that referenced
this pull request
Jul 8, 2020
* Big refactor of reauth / link + basic idp tasks * PR feedback * Formatting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.