Skip to content

Export some unchanged members for the full Firestore "exp" SDK #3256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2020
Merged

Export some unchanged members for the full Firestore "exp" SDK #3256

merged 1 commit into from
Jun 24, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Jun 23, 2020 •
edited
Loading

This adds some exports to the full tree-shakeable Firestore SDK for some of the existing APIs that can be exported without modification.

@schmidt-sebastian schmidt-sebastian changed the title Export some unchanged members in the firestore/exp SDK Export some unchanged members for the full Firestore "exp" SDK Jun 23, 2020
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • @firebase/firestore/exp

    Type Base (58e1b6f) Head (33d045b) Diff
    main ? 38.2 kB ? (?)

Test Logs

@rafikhan
Copy link
Contributor

LGTM

@schmidt-sebastian schmidt-sebastian merged commit c436bcc into master Jun 24, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/exp branch July 9, 2020 17:45
@firebase firebase locked and limited conversation to collaborators Jul 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rafikhan rafikhan rafikhan approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @rafikhan