Make LocalStore an interface. #3269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary Size ReportAffected SDKs
Test Logs
|
schmidt-sebastian
approved these changes
Jun 24, 2020
| * Implements `LocalStore` interface. | ||
| * | ||
| * Note: some field defined in this class might have public access level, but | ||
| * the class is not exported so they are only accessible from this file. This is |
There was a problem hiding this comment.
s/file/module (the JS specific term)
| rejectBatch(batchId: BatchId): Promise<MaybeDocumentMap>; | ||
|
|
||
| /** | ||
| * Returns the largest (latest) batch id in mutation queue that is pending server response. |
There was a problem hiding this comment.
This line wrap looks off.
| * useful to implement optional features (like bundles) in free functions, such | ||
| * that they are tree-shakeable. | ||
| */ | ||
| class LocalStoreImpl implements LocalStore { |
There was a problem hiding this comment.
Do you mind removing the JSDocs that you copied over? It is too easy for them to go out of sync now that they are in two places.
| /** | ||
| * An implementation of LocalStore that provides additional functionality | ||
| * for MultiTabSyncEngine. | ||
| * | ||
| * Note: some field defined in this class might have public access level, but | ||
| * the class is not exported so they are only accessible from this file. This is |
There was a problem hiding this comment.
s/file/module
Please also remove duplicate comments for MultiTabLocalStoreImpl.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make LocalStore an interface and have
LocalStoreImpl implements LocalStore. Public fields inLocalStoreImplthen becomes file private, becauseLocalStoreImplis not exported.