Skip to content

Reduce size impact of Target/TargetImpl pattern #3272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 26, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

No description provided.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 24, 2020

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (8e0c036) Head (ff5ad2e) Diff
    browser 248 kB 248 kB -495 B (-0.2%)
    esm2017 194 kB 193 kB -392 B (-0.2%)
    main 494 kB 492 kB -1.08 kB (-0.2%)
    module 246 kB 245 kB -485 B (-0.2%)
  • @firebase/firestore/exp

    Type Base (8e0c036) Head (ff5ad2e) Diff
    main 37.4 kB 272 kB +234 kB (+627.6%)
  • @firebase/firestore/lite

    Type Base (8e0c036) Head (ff5ad2e) Diff
    main 140 kB 140 kB +285 B (+0.2%)
  • @firebase/firestore/memory

    Type Base (8e0c036) Head (ff5ad2e) Diff
    browser 186 kB 186 kB -495 B (-0.3%)
    esm2017 145 kB 145 kB -392 B (-0.3%)
    main 363 kB 362 kB -1.08 kB (-0.3%)
    module 184 kB 184 kB -485 B (-0.3%)
  • firebase

    Type Base (8e0c036) Head (ff5ad2e) Diff
    firebase-firestore.js 287 kB 286 kB -485 B (-0.2%)
    firebase-firestore.memory.js 226 kB 225 kB -485 B (-0.2%)
    firebase.js 820 kB 819 kB -486 B (-0.1%)

Test Logs

@changeset-bot
Copy link

changeset-bot bot commented Jun 26, 2020

🦋 Changeset is good to go

Latest commit: 8fa74c1

We got this.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@schmidt-sebastian schmidt-sebastian merged commit 7d4e095 into master Jun 26, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/targetinterface branch July 9, 2020 17:45
@firebase firebase locked and limited conversation to collaborators Jul 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants