Skip to content

Address (some) of the tree shaking issues w/ ReCaptcha #3277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 24, 2020
Merged

Address (some) of the tree shaking issues w/ ReCaptcha #3277

merged 2 commits into from
Jun 24, 2020

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Jun 24, 2020

  • Remove global exported consts
  • Remove get property, replaced w/ traditional method

@sam-gc sam-gc requested a review from avolkovi June 24, 2020 22:22
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (e05a20c) and head commit (efd447f).

Test Logs

avolkovi
avolkovi approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@avolkovi avolkovi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, do we need API review though?

@avolkovi avolkovi assigned sam-gc and unassigned avolkovi Jun 24, 2020
@sam-gc
Copy link
Contributor Author

sam-gc commented Jun 24, 2020

No, these changes are 100% internal workings of the SDK.

Now the other updates to ReCaptcha that I outlined in the doc I shared with you will require an API review

@sam-gc sam-gc merged commit 8948954 into auth-next Jun 24, 2020
@sam-gc sam-gc deleted the samgho/recaptcha_changes branch June 24, 2020 23:53
avolkovi pushed a commit that referenced this pull request Jul 8, 2020
@sam-gc @avolkovi
Address (some) of the tree shaking issues w/ ReCaptcha (#3277)
b254605 
* Address (some) of the recaptcha tree-shaking issues

* Formatting
@firebase firebase locked and limited conversation to collaborators Jul 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@avolkovi avolkovi avolkovi approved these changes

@Feiyang1 Feiyang1 Awaiting requested review from Feiyang1

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@hsubox76 hsubox76 Awaiting requested review from hsubox76 hsubox76 is a code owner

Assignees

@sam-gc sam-gc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sam-gc @google-oss-bot @avolkovi