Skip to content

Move FCM Integration Test off test flows #3287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 26, 2020
Merged

Conversation

zwu52
Copy link
Member

@zwu52 zwu52 commented Jun 25, 2020

Looks like part of the FCM integration test is flaky. Specifically update-token and delete-token. See below for a snippet of error message:

@firebase/messaging:   1) Firebase Messaging Integration Tests > get and delete token
@firebase/messaging:        Testing browser: Google Chrome Stable : valid-vapid-key
@firebase/messaging:          Test app can delete a valid token:
@firebase/messaging:      Error: Timeout of 100000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/firebase-js-sdk/firebase-js-sdk/integration/messaging/test/test-deleteToken.js)

Looking at the actions history, it looks like its affecting "test-all" and "test-modified". Moving them off workflow so that folks don't have to rerun the tests to get a green result.

@changeset-bot
Copy link

changeset-bot bot commented Jun 25, 2020

🦋 Changeset is good to go

Latest commit: 65f6f9d

We got this.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 25, 2020

Binary Size Report

Affected SDKs

No changes between base commit (8e0c036) and head commit (cac6841).

Test Logs

@zwu52 zwu52 requested a review from schmidt-sebastian June 26, 2020 18:54
@zwu52 zwu52 merged commit ddbe218 into master Jun 26, 2020
@zwu52 zwu52 changed the title Disable Cross Browser FCM Integration Test Move FCM Integration Test off test flows Jun 26, 2020
@firebase firebase locked and limited conversation to collaborators Jul 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants