Tree shakeable persistence #3288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💥 No ChangesetLatest commit: 088cb6b Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
Binary Size ReportAffected SDKsNo changes between base commit (b9ece92) and head commit (2e6a6cd). Test Logs
|
avolkovi
reviewed
Jun 25, 2020
avolkovi
reviewed
Jun 25, 2020
avolkovi
reviewed
Jun 25, 2020
avolkovi
approved these changes
Jul 7, 2020
sam-gc
force-pushed
the
samgho/tree-shakeable-persistence
branch
from
2050942 to
9e4b6aa
Compare
avolkovi
pushed a commit
that referenced
this pull request
Jul 8, 2020
* Make the persistence objects tree-shakeable * Formatting * Updated to stop using casts everywhere * Formatting * Make the browser impls tree shakeable * Formatting * Fix the react native implementation in auth-compat-exp * Formatting * Make the react native class wrapped in a closure, to avoid the prototype nonsense * Formatting * Fix index.rn.ts * Formatting * PR feedback * Fix ordering in index.ts * Formatting * Fix test * Formatting
avolkovi
pushed a commit
that referenced
this pull request
Aug 6, 2020
* Make the persistence objects tree-shakeable * Formatting * Updated to stop using casts everywhere * Formatting * Make the browser impls tree shakeable * Formatting * Fix the react native implementation in auth-compat-exp * Formatting * Make the react native class wrapped in a closure, to avoid the prototype nonsense * Formatting * Fix index.rn.ts * Formatting * PR feedback * Fix ordering in index.ts * Formatting * Fix test * Formatting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exporting
consts that are instantiated using a function call (like a constructor) can't be tree shaken since the tools don't know whether or not the function side-effects. To get around this while keeping the appearance of exportedconsts that the user can use, the classes themselves take on the shape of theexterns.Persistenceinterface, and provide internal static methods for instantiation.I've verified in the demo build that this will indeed allow all of these persistence classes to be tree-shaken. This also does not change the API surface at all as far as the user is concerned.