Add getQuery(), getQueryFromCache() and getQueryFromServer() #3294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 97f9664 We got this. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Binary Size ReportAffected SDKs
Test Logs
|
rafikhan
requested changes
Jun 26, 2020
| ): Promise<QuerySnapshot<T>> { | ||
| const internalQuery = cast<Query<T>>(query, Query); | ||
| const firestore = cast<Firestore>(query.firestore, Firestore); | ||
| return firestore._getFirestoreClient().then(async firestoreClient => { |
There was a problem hiding this comment.
Can you make methods like this fully async? I'm not seeing why they need mixed notation. This applies to the other functions below.
There was a problem hiding this comment.
The outermost code needs to be async to ensure synchronous function execution, which impacts error propagation and execution order. The cast calls here, for example, would not throw but cause rejected Promises.
rafikhan
approved these changes
Jun 26, 2020
…ase-js-sdk into mrschmidt/getdocfromcache
schmidt-sebastian
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
schmidt-sebastian
changed the base branch from
mrschmidt/getdocfromcache
to
master
schmidt-sebastian
requested review from
alikn,
andirayo,
avolkovi,
egilmorez,
erikeldridge,
sam-gc,
scottcrossen,
yuchenshi,
zijianjoy and
zwu52
as code owners
schmidt-sebastian
added a commit
that referenced
this pull request
Jun 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds getQuery(), getQueryFromCache() and getQueryFromServer() as well as a QuerySnapshot that is heavily inspired by the existing SDK's QuerySnapshot.
Most code churn is to allow code reuse.