Add setDoc, updateDoc, deleteDoc and addDoc #3306
Conversation
🦋 Changeset is good to goLatest commit: f72c161 We got this. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Binary Size ReportAffected SDKsNo changes between base commit (5d6b749) and head commit (e0c9b65). Test Logs
|
|
|
||
| return firestore | ||
| ._getFirestoreClient() | ||
| .then(firestoreClient => |
There was a problem hiding this comment.
Same comment from previous PR's. Why is there chaining instead of just using async/await?
There was a problem hiding this comment.
Same response: )
"The outermost code needs to be async to ensure synchronous function execution, which impacts error propagation and execution order. The cast calls here, for example, would not throw but cause rejected Promises."
In this case, this also impact user input validation, which we want to throw as it is likely caused by invalid SDK usage.
schmidt-sebastian
requested review from
alikn,
andirayo,
avolkovi,
davideast,
egilmorez,
erikeldridge,
Feiyang1,
hiranya911,
hsubox76,
jamesdaniels and
jsdt
as code owners
schmidt-sebastian
requested review from
sam-gc,
scottcrossen,
yuchenshi,
zijianjoy and
zwu52
as code owners
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly. In order to pass this check, please resolve this problem and then comment ℹ️ Googlers: Go here for more info. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
While this is a large PR, this is mostly a copy of code from the Lite SDK, but instead of Datastore it uses FirestoreClient to commit the write (which adds it to LocalStore first).