Skip to content

Fix updateToken #3312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2020
Merged

Fix updateToken #3312

merged 2 commits into from
Jun 27, 2020

Conversation

Feiyang1
Copy link
Member

It seems we are saving the old token back to indexeddb instead of the new token. The PR fixes it.

@Feiyang1 Feiyang1 requested a review from zwu52 as a code owner June 26, 2020 23:26
@changeset-bot
Copy link

changeset-bot bot commented Jun 26, 2020

🦋 Changeset is good to go

Latest commit: d08ef25

We got this.

This PR includes changesets to release 10 packages
Name Type
@firebase/messaging Patch
firebase Patch
@firebase/functions Patch
@firebase/functions-exp Patch
@firebase/testing Patch
firebase-browserify-test Patch
firebase-package-typings-test Patch
firebase-messaging-selenium-test Patch
firebase-typescript-test Patch
firebase-webpack-test Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 26, 2020

Binary Size Report

Affected SDKs

  • @firebase/messaging

    Type Base (e90304c) Head (8655c66) Diff
    esm2017 23.2 kB 23.2 kB +18 B (+0.1%)
    main 31.3 kB 31.4 kB +19 B (+0.1%)
    module 30.9 kB 30.9 kB +13 B (+0.0%)
  • firebase

    Type Base (e90304c) Head (8655c66) Diff
    firebase-messaging.js 39.1 kB 39.1 kB +6 B (+0.0%)
    firebase.js 819 kB 819 kB +7 B (+0.0%)

Test Logs

@Feiyang1 Feiyang1 merged commit 17c628e into master Jun 27, 2020
@Feiyang1 Feiyang1 deleted the fei-msg-fix branch June 27, 2020 00:02
schmidt-sebastian pushed a commit that referenced this pull request Jun 30, 2020
* fix assignment order

* Create cuddly-rivers-add.md
@github-actions github-actions bot mentioned this pull request Jul 6, 2020
@firebase firebase locked and limited conversation to collaborators Jul 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants