Run integration/firestore tests in Saucelabs #3319
Conversation
💥 No ChangesetLatest commit: 723b750 Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
Binary Size ReportAffected SDKs
Test Logs
|
hsubox76
force-pushed
the
ch-firestore-sl-integration
branch
from
b4b2e9f to
2fca07a
Compare
| `${path.dirname(require.resolve('firebase'))}/firebase-firestore.js`, | ||
| './dist/test-harness.js' | ||
| ]; | ||
| const files = ['./dist/test-harness.js']; |
There was a problem hiding this comment.
These files are not necessary (and I think not there), that code is built into test-harness.js now.
config/karma.saucelabs.js
Outdated
| firestore: { | ||
| // Firestore unit tests have OOM problems compiling with Babel for IE. | ||
| // Firestore integration/firestore tests do run on all browsers. | ||
| 'packages/firestore': { |
There was a problem hiding this comment.
The key is a bit confusing until I read more code below. Can we use the package name (@firebase/firestore) instead to make it easier to understand?
scripts/run_saucelabs.js
Outdated
| // When test queue is empty, exit with code 0 if no tests failed or | ||
| // 1 if any tests failed. | ||
| if (!testFiles.length) process.exit(maxExitCode); | ||
| if (!testFiles.length) { | ||
| for (const fileName in results) { |
There was a problem hiding this comment.
Nit: for (const fileName of Object.key(results)) to include only OwnProperties.
hsubox76
changed the title
Enable Firestore integration tests (
integration/firestore/karma.conf.js) to be run in Saucelabs in addition to unit tests (packages/firestore/karma.conf.js). Unit tests still have issues running in IE, due to Babel OOM issues, but integration tests should work. Needed to add anisNaN()polyfill as well.Disabled namespace integration tests as they are not very useful in cross-browser tests.