Add onSnapshotsInSync to firestore-exp #3320
Conversation
🦋 Changeset is good to goLatest commit: 042f2c7 We got this. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
schmidt-sebastian
requested review from
alikn,
andirayo,
avolkovi,
egilmorez,
erikeldridge,
sam-gc,
scottcrossen,
yuchenshi,
zijianjoy and
zwu52
as code owners
Binary Size ReportAffected SDKs
Test Logs
|
…ebase-js-sdk into mrschmidt/onsnapshotsinsync
schmidt-sebastian
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly. In order to pass this check, please resolve this problem and then comment ℹ️ Googlers: Go here for more info. |
| @@ -675,6 +657,29 @@ export class Firestore implements firestore.FirebaseFirestore, FirebaseService { | |||
| } | |||
| } | |||
|
|
|||
| /** Register the listener for onSnapshotsInSync() */ | |||
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
This adds the code for onSnapshotsInSync, tests are coming when we can target the existing integration tests against firestore-exp