Skip to content

Don't use UserDataReader for Increment transform #3332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

Small simplification for the NumericIncrementFieldValueImpl, which doesn't need a UserDataReader to convert a number into a number.

@changeset-bot
Copy link

changeset-bot bot commented Jul 1, 2020

🦋 Changeset is good to go

Latest commit: 0834a59

We got this.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 1, 2020

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (a754645) Head (2782130) Diff
    browser 248 kB 248 kB -4 B (-0.0%)
    esm2017 194 kB 194 kB -4 B (-0.0%)
    main 493 kB 493 kB -79 B (-0.0%)
    module 246 kB 246 kB -4 B (-0.0%)
    react-native 194 kB 194 kB -4 B (-0.0%)
  • @firebase/firestore/exp

    Type Base (a754645) Head (2782130) Diff
    main 395 kB 395 kB -83 B (-0.0%)
  • @firebase/firestore/lite

    Type Base (a754645) Head (2782130) Diff
    main 141 kB 141 kB -83 B (-0.1%)
  • @firebase/firestore/memory

    Type Base (a754645) Head (2782130) Diff
    browser 186 kB 186 kB -4 B (-0.0%)
    esm2017 145 kB 145 kB -9 B (-0.0%)
    main 363 kB 363 kB -79 B (-0.0%)
    module 184 kB 184 kB -4 B (-0.0%)
    react-native 145 kB 145 kB -9 B (-0.0%)
  • firebase

    Type Base (a754645) Head (2782130) Diff
    firebase-firestore.js 286 kB 286 kB +9 B (+0.0%)
    firebase-firestore.memory.js 226 kB 226 kB +12 B (+0.0%)
    firebase.js 820 kB 820 kB +9 B (+0.0%)

Test Logs

@schmidt-sebastian schmidt-sebastian merged commit 0c8b011 into master Jul 1, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/increment branch July 9, 2020 17:44
@firebase firebase locked and limited conversation to collaborators Aug 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants