Skip to content

Add popup util and bare-bones OAuthProvider #3335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 6, 2020
Merged

Add popup util and bare-bones OAuthProvider #3335

merged 6 commits into from
Jul 6, 2020

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Jul 1, 2020

No description provided.

@sam-gc sam-gc requested a review from avolkovi July 1, 2020 19:59
@changeset-bot
Copy link

changeset-bot bot commented Jul 1, 2020 •
edited
Loading

💥 No Changeset

Latest commit: d28343d

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 1, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (c46e3b9) and head commit (8879d37).

Test Logs

avolkovi
avolkovi reviewed Jul 1, 2020
View reviewed changes
packages-exp/auth-exp/src/core/util/popup.ts Outdated

// Chrome iOS 7 and 8 is returning an undefined popup win when target is
// specified, even though the popup is not necessarily blocked.
const ua = _uaGetter.getUA().toLowerCase();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the helpers in firebase/util please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just so that we can stub this out in test without importing all of firebase/util.

The import * as <something> from '...' works for stubbing BUT it also will break tree shaking (the entire module will be imported).

This is fine when there's only one or two functions in that module, but for something like firebase/util, it's a no-go

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we only need to do the import * as something in the tests, righty? in the implementation you can just pull in the method you want, either way we pull the UA helpers elsewhere

@sam-gc sam-gc force-pushed the samgho/oauth_provider_utils branch from eaf7d11 to 78d36f0 Compare July 6, 2020 17:50
@avolkovi avolkovi assigned sam-gc and unassigned avolkovi Jul 6, 2020
@sam-gc sam-gc changed the base branch from samgho/gapi_iframe to auth-next July 6, 2020 18:53
@sam-gc sam-gc force-pushed the samgho/oauth_provider_utils branch from 00d79b4 to d28343d Compare July 6, 2020 19:00
@sam-gc sam-gc merged commit 29e0472 into auth-next Jul 6, 2020
avolkovi pushed a commit that referenced this pull request Jul 8, 2020
@sam-gc @avolkovi
Add popup util and bare-bones OAuthProvider (#3335)
0da2baa
@firebase firebase locked and limited conversation to collaborators Aug 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@avolkovi avolkovi avolkovi approved these changes

@Feiyang1 Feiyang1 Awaiting requested review from Feiyang1

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@hsubox76 hsubox76 Awaiting requested review from hsubox76 hsubox76 is a code owner

Assignees

@sam-gc sam-gc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sam-gc @google-oss-bot @avolkovi