Skip to content

Add browser popup resolver class, some utils #3336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 8, 2020
Merged

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Jul 1, 2020

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jul 1, 2020

💥 No Changeset

Latest commit: 1a24815

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 1, 2020

Binary Size Report

Affected SDKs

No changes between base commit (9d7a434) and head commit (485714f).

Test Logs

@sam-gc sam-gc force-pushed the samgho/oauth_provider_utils branch from eaf7d11 to 78d36f0 Compare July 6, 2020 17:50
@sam-gc sam-gc force-pushed the samgho/event_manager branch from 216aa70 to 5f980bf Compare July 6, 2020 18:30
@sam-gc sam-gc force-pushed the samgho/oauth_provider_utils branch from 00d79b4 to d28343d Compare July 6, 2020 19:00
@sam-gc sam-gc changed the base branch from samgho/oauth_provider_utils to auth-next July 6, 2020 19:21
@sam-gc sam-gc force-pushed the samgho/event_manager branch from d02d146 to ff3d15f Compare July 6, 2020 19:24
@avolkovi avolkovi assigned sam-gc and unassigned avolkovi Jul 7, 2020
@sam-gc sam-gc force-pushed the samgho/event_manager branch from ff3d15f to 1a24815 Compare July 8, 2020 18:33
@sam-gc sam-gc merged commit a4eade4 into auth-next Jul 8, 2020
@sam-gc sam-gc deleted the samgho/event_manager branch July 8, 2020 18:34
avolkovi pushed a commit that referenced this pull request Jul 8, 2020
* Add auth event manager and popup_redirect browser implementation

* Add browser popup implementation, some utils

* Formatting

* PR feedback

* Formatting

* Fix failing tests

* formatting
avolkovi pushed a commit that referenced this pull request Aug 6, 2020
* Add auth event manager and popup_redirect browser implementation

* Add browser popup implementation, some utils

* Formatting

* PR feedback

* Formatting

* Fix failing tests

* formatting
@firebase firebase locked and limited conversation to collaborators Aug 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants