Make the _getInstance() instantiator a util for the whole SDK #3369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💥 No ChangesetLatest commit: bf45fba Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
avolkovi
reviewed
Jul 8, 2020
avolkovi
reviewed
Jul 8, 2020
avolkovi
approved these changes
Jul 8, 2020
Binary Size ReportAffected SDKsNo changes between base commit (2070553) and head commit (ed4ba17). Test Logs
|
avolkovi
pushed a commit
that referenced
this pull request
Jul 8, 2020
* Make the _getInstance() instantiator a util for the whole SDK * PR feedback, added some debugAsserts * Formatting
avolkovi
pushed a commit
that referenced
this pull request
Aug 6, 2020
* Make the _getInstance() instantiator a util for the whole SDK * PR feedback, added some debugAsserts * Formatting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.