Skip to content

Add type to DocumentReference/CollectionReference/Query #3402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

As per go/firestore-next-amendment

@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2020

💥 No Changeset

Latest commit: fa060c9

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • @firebase/firestore/exp

    Type Base (b07f822) Head (4694330) Diff
    main 400 kB 400 kB +62 B (+0.0%)
  • @firebase/firestore/lite

    Type Base (b07f822) Head (4694330) Diff
    main 124 kB 124 kB +62 B (+0.0%)

Test Logs

Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schmidt-sebastian schmidt-sebastian merged commit 6d5b4cc into master Jul 16, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/typeprops branch July 17, 2020 01:40
@schmidt-sebastian schmidt-sebastian mentioned this pull request Jul 20, 2020
@firebase firebase locked and limited conversation to collaborators Aug 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants