Skip to content

Populate enrolled factors on reload() #3406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2020

Conversation

avolkovi
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jul 14, 2020

💥 No Changeset

Latest commit: 595dc8f

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (37e930c) and head commit (cc0aa25).

Test Logs


_notifyReloadListener(userInfo: APIUserInfo): void {
if (this.reloadListener) {
this.reloadListener(userInfo);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not set this.reloadUserInfo = null here instead of on line 118?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the check next to the use, that way the logic is check, use, null-out, we don't actually use reloadUserInfo in _notifyReloadListener so it seems a bit off to null it out without using it

@avolkovi avolkovi merged commit 1c5910d into auth-next Jul 15, 2020
@avolkovi avolkovi deleted the avolkovi/mfa-enrolled-factors branch July 15, 2020 20:03
avolkovi added a commit that referenced this pull request Aug 6, 2020
avolkovi added a commit that referenced this pull request Aug 10, 2020
@firebase firebase locked and limited conversation to collaborators Aug 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants