Update the auth event manager to handle redirects. Add redirect logic to popupredirectresolver #3409
Conversation
💥 No ChangesetLatest commit: a2d6336 Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
Binary Size ReportAffected SDKsNo changes between base commit (37e930c) and head commit (4a81c74). Test Logs
|
| @@ -50,26 +50,17 @@ import { | |||
| signInWithCustomToken, | |||
| signInWithEmailAndPassword, | |||
| unlink, | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
how'd we get a merge conflict in the main branch?
| } | ||
|
|
||
| unregisterConsumer(authEventConsumer: AuthEventConsumer): void { | ||
| this.consumers.delete(authEventConsumer); | ||
| } | ||
|
|
||
| onEvent(event: AuthEvent): void { | ||
| onEvent(event: AuthEvent): boolean { |
There was a problem hiding this comment.
this is ok... potentially worth refactoring eventually to handle redirect events in a completely separate path from popup events
There was a problem hiding this comment.
Agreed. Added a comment in popup_redirect.ts
… to popupredirectresolver (#3409) * Update event manager and abstract popup redirect operation to handle redirect events * Missing popup_redirect update * Tests * Formatting * PR feedback * Formatting
… to popupredirectresolver (#3409) * Update event manager and abstract popup redirect operation to handle redirect events * Missing popup_redirect update * Tests * Formatting * PR feedback * Formatting
No description provided.