Add persistence for redirect users #3410
Conversation
💥 No ChangesetLatest commit: 12bc538 Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
Binary Size ReportAffected SDKsNo changes between base commit (d59ed26) and head commit (95b2c42). Test Logs
|
| @@ -76,9 +83,25 @@ export class AuthImpl implements Auth { | |||
| persistenceHierarchy | |||
| ); | |||
|
|
|||
| this.redirectPersistenceManager = await PersistenceUserManager.create( | |||
There was a problem hiding this comment.
is there a way to not have the redirect logic baked into auth? can we do a callback or something with the resolver if it's registered?
There was a problem hiding this comment.
(chatted offline)
Uploaded new version
sam-gc
force-pushed
the
samgho/auth_redirect_persistence
branch
from
aae8964 to
aeb2875
Compare
| return this.reloadAndSetCurrentUserOrClear(storedUser); | ||
| } | ||
|
|
||
| assert(popupRedirectResolver, this.name, AuthErrorCode.ARGUMENT_ERROR); |
There was a problem hiding this comment.
we may want a more user friendly error here
There was a problem hiding this comment.
on the one hand: yes. on the other: this promise is not returned to the user so they'll never see it 😬
* Updates to auth for persistence redirect user * Add tests for persistence * Formatting * Removing erroneous console.logs * Formatting * Updates to the auth init flow * Formatting * Fix typo * Formatting * Rogue console.logwq * Formatting * PR feedback * Formatting
* Updates to auth for persistence redirect user * Add tests for persistence * Formatting * Removing erroneous console.logs * Formatting * Updates to the auth init flow * Formatting * Fix typo * Formatting * Rogue console.logwq * Formatting * PR feedback * Formatting
No description provided.