Move Datastore to ComponentProvider #3417
Conversation
💥 No ChangesetLatest commit: e77b203 Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
Binary Size ReportAffected SDKs
Test Logs
|
| const serializer = newSerializer(databaseInfo.databaseId); | ||
| const datastore = newDatastore(conn, credentialsProvider, serializer); | ||
| const datastore = newDatastore(credentialsProvider, serializer); | ||
| await datastore.start(conn); |
There was a problem hiding this comment.
Hmm, how does this work with await? start doesn't seem to be async.
There was a problem hiding this comment.
"await" returns the value that is being awaited even if it is not a Promise, so it should work. That being said, we should still drop it here. Thanks for catching.
This is the first step in my two step plan to split up the ComponentProvider into one that provides only the components that are needed to reach from cache and into one that provides the RemoteStore and other components needed for connectivity.