Skip to content

Move all of our helper files in test/ to a new directory test/helpers/ #3452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2020

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Jul 22, 2020

No description provided.

@sam-gc sam-gc requested a review from avolkovi July 22, 2020 17:36
@changeset-bot
Copy link

changeset-bot bot commented Jul 22, 2020

💥 No Changeset

Latest commit: a63dada

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@malcolmdeck malcolmdeck self-requested a review July 22, 2020 18:12
Copy link

@malcolmdeck malcolmdeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp - LGTM

@sam-gc sam-gc merged commit ae4f6e6 into auth-next Jul 22, 2020
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (a675463) and head commit (ee825eb).

Test Logs

avolkovi pushed a commit that referenced this pull request Aug 6, 2020
#3452)

* Move all of our helper files in test/ to a new directory test/helpers/

* Formatting
avolkovi pushed a commit that referenced this pull request Aug 10, 2020
#3452)

* Move all of our helper files in test/ to a new directory test/helpers/

* Formatting
@firebase firebase locked and limited conversation to collaborators Aug 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants