-
Notifications
You must be signed in to change notification settings - Fork 945
Refactor the way UserCredentials work in anticipation of mudularization #3489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💥 No ChangesetLatest commit: e1ce16f Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
Binary Size ReportAffected SDKsNo changes between base commit (e2efd27) and head commit (af23e80). Test Logs
|
…on (#3489) * Refactor the way UserCredentials work in anticipation of mudularization * Formatting * PR feedback * Linter fixes * Formatting
…on (#3489) * Refactor the way UserCredentials work in anticipation of mudularization * Formatting * PR feedback * Linter fixes * Formatting
Basically:
Instead of interpreting the result of the IdTokenResponse as soon as it comes in, we delay that until the user directly requests it.
Before:
After:
This saves pulling in at least four different unnecessary classes