return FirebaseData from initStandalone

[Feiyang1]

No description provided.

[google-oss-bot]

Binary Size Report

Affected SDKs

No changes between base commit (3a9eaac) and head commit (ecbf979).

Test Logs

• Base (3a9eaac9): https://github.com/firebase/firebase-js-sdk/actions/runs/185169164
• Head (ecbf9793): https://github.com/firebase/firebase-js-sdk/actions/runs/185973011

[schmidt-sebastian]

LGTM, though I wonder if we should do this for all callsites (or change the return type of the method).

[Feiyang1]

What other callsites? We are changing the the return type of the method. The return type is inferred from the returned object.

[schmidt-sebastian]

You could change https://osscs.corp.google.com/firebase-sdk/firebase-js-sdk/+/master:packages/database/src/core/RepoManager.ts;l=103?q=databaseFromApp&ss=firebase-sdk%2Ffirebase-js-sdk,
which would also affect https://osscs.corp.google.com/firebase-sdk/firebase-js-sdk/+/master:packages/database/index.ts;l=52?q=databaseFromApp&ss=firebase-sdk%2Ffirebase-js-sdk and https://osscs.corp.google.com/firebase-sdk/firebase-js-sdk/+/master:packages/database/index.node.ts;l=112?q=databaseFromApp&ss=firebase-sdk%2Ffirebase-js-sdk. These changes are technically no-ops, but feel like the right thing to do. Optional.