Skip to content

Add the remaining oauth providers #3500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 29, 2020
Merged

Add the remaining oauth providers #3500

merged 3 commits into from
Jul 29, 2020
+491 −12

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Jul 28, 2020

No description provided.

@sam-gc sam-gc requested a review from avolkovi July 28, 2020 21:27
@changeset-bot
Copy link

changeset-bot bot commented Jul 28, 2020 •
edited
Loading

💥 No Changeset

Latest commit: 4e3964b

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 28, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (8fe55d9) and head commit (3f2fa66).

Test Logs

@sam-gc sam-gc force-pushed the samgho/oauth-providers branch from de1653f to 96ddd89 Compare July 28, 2020 22:08
@sam-gc sam-gc force-pushed the samgho/more-oauth branch from c0d29df to fef87eb Compare July 28, 2020 22:15
Base automatically changed from samgho/oauth-providers to auth-next July 29, 2020 17:23
@sam-gc sam-gc force-pushed the samgho/more-oauth branch from fef87eb to 4e3964b Compare July 29, 2020 17:28
avolkovi
avolkovi approved these changes Jul 29, 2020
View reviewed changes
packages-exp/auth-exp/src/core/providers/facebook.ts
});
}

static credentialFromResult(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can these be defined in OAuthProvider?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately no, since they're all subtly different and TS has no concept of static abstract functions

@sam-gc sam-gc merged commit 78df2a6 into auth-next Jul 29, 2020
@sam-gc sam-gc deleted the samgho/more-oauth branch July 29, 2020 19:17
avolkovi pushed a commit that referenced this pull request Aug 6, 2020
@sam-gc @avolkovi
Add the remaining oauth providers (#3500)
02147ef 
* Add the rest of the OAuth providers

* Formatting

* Add to demo
avolkovi pushed a commit that referenced this pull request Aug 10, 2020
@sam-gc @avolkovi
Add the remaining oauth providers (#3500)
a8e91fe 
* Add the rest of the OAuth providers

* Formatting

* Add to demo
@firebase firebase locked and limited conversation to collaborators Aug 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@avolkovi avolkovi avolkovi approved these changes

@Feiyang1 Feiyang1 Awaiting requested review from Feiyang1

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@hsubox76 hsubox76 Awaiting requested review from hsubox76 hsubox76 is a code owner

Assignees

@avolkovi avolkovi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sam-gc @google-oss-bot @avolkovi