Skip to content

Remove TransactionRunner when not used #3539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 3, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Aug 3, 2020

This PR removes the hard dependency on Transaction/TransactionRunner from code that doesn't use it (for firestore-exp).

@changeset-bot
Copy link

changeset-bot bot commented Aug 3, 2020

💥 No Changeset

Latest commit: 7c383e9

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 3, 2020

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (0966416) Head (dfd15ca) Diff
    browser 247 kB 247 kB -111 B (-0.0%)
    esm2017 193 kB 193 kB -67 B (-0.0%)
    main 472 kB 472 kB -195 B (-0.0%)
    module 244 kB 244 kB -111 B (-0.0%)
    react-native 193 kB 193 kB -67 B (-0.0%)
  • @firebase/firestore/exp

    Type Base (0966416) Head (dfd15ca) Diff
    browser 187 kB 187 kB -78 B (-0.0%)
    main 465 kB 464 kB -256 B (-0.1%)
    module 187 kB 187 kB -78 B (-0.0%)
    react-native 187 kB 187 kB -78 B (-0.0%)
  • @firebase/firestore/memory

    Type Base (0966416) Head (dfd15ca) Diff
    browser 186 kB 185 kB -111 B (-0.1%)
    esm2017 145 kB 145 kB -67 B (-0.0%)
    main 347 kB 347 kB -195 B (-0.1%)
    module 184 kB 183 kB -111 B (-0.1%)
    react-native 145 kB 145 kB -67 B (-0.0%)
  • firebase

    Type Base (0966416) Head (dfd15ca) Diff
    firebase-firestore.js 286 kB 286 kB -113 B (-0.0%)
    firebase-firestore.memory.js 226 kB 226 kB -113 B (-0.0%)
    firebase.js 819 kB 819 kB -113 B (-0.0%)

Test Logs

@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt/byebyetransaction branch from 1e2f38f to 4972d05 Compare August 3, 2020 05:02
@schmidt-sebastian schmidt-sebastian changed the title WIP Remove TransactionRunner Remove TransactionRunner Aug 3, 2020
@schmidt-sebastian schmidt-sebastian changed the title Remove TransactionRunner Remove TransactionRunner when not used Aug 3, 2020
Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, good eye in spotting this 🕵️

@schmidt-sebastian schmidt-sebastian merged commit 9c13104 into master Aug 3, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/byebyetransaction branch August 10, 2020 19:14
@firebase firebase locked and limited conversation to collaborators Sep 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants