Clean up our to/from JSON implementations #3606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avolkovi
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
💥 No ChangesetLatest commit: 8ec6f1e Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
avolkovi
force-pushed
the
avolkovi/json
branch
2 times, most recently
from
46fbfb5 to
7f2e70e
Compare
Binary Size ReportAffected SDKsNo changes between base commit (f1de10e) and head commit (adb60da). Test Logs
|
avolkovi
force-pushed
the
avolkovi/json
branch
from
7f2e70e to
c01b7a6
Compare
sam-gc
reviewed
Aug 11, 2020
avolkovi
commented
Aug 12, 2020
avolkovi
commented
Aug 12, 2020
avolkovi
commented
Aug 12, 2020
avolkovi
commented
Aug 12, 2020
avolkovi
commented
Aug 12, 2020
avolkovi
commented
Aug 12, 2020
avolkovi
commented
Aug 12, 2020
avolkovi
commented
Aug 12, 2020
sam-gc
reviewed
Aug 12, 2020
- Remove anonymous credential/provider since they're not exposed and don't do anything - rename toPlainObject on User to toJSON per API spec - relax restrictions around ProviderId & SignInMethod typing since they can sometimes have values outside of our enum
avolkovi
force-pushed
the
avolkovi/json
branch
from
cc46497 to
8ec6f1e
Compare
sam-gc
approved these changes
Aug 12, 2020
sam-gc
pushed a commit
that referenced
this pull request
Sep 1, 2020
* Clean up our to/from JSON implementations - Remove anonymous credential/provider since they're not exposed and don't do anything - rename toPlainObject on User to toJSON per API spec - relax restrictions around ProviderId & SignInMethod typing since they can sometimes have values outside of our enum * PR feedback and more cleanup * Rejigger our error type checking to allow app-less errors * PR feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
don't do anything
can sometimes have values outside of our enum