Implement cross-window browser events for auth-next #3631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💥 No ChangesetLatest commit: 3a324fb Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
avolkovi
commented
Aug 13, 2020
packages-exp/auth-exp/src/core/persistence/persistence_user_manager.ts
Outdated
Show resolved
Hide resolved
sam-gc
reviewed
Aug 13, 2020
sam-gc
reviewed
Aug 13, 2020
packages-exp/auth-exp/src/core/persistence/persistence_user_manager.ts
Outdated
Show resolved
Hide resolved
sam-gc
reviewed
Aug 13, 2020
packages-exp/auth-exp/src/platform_browser/persistence/browser.ts
Outdated
Show resolved
Hide resolved
sam-gc
reviewed
Aug 13, 2020
packages-exp/auth-exp/src/platform_browser/persistence/browser.ts
Outdated
Show resolved
Hide resolved
sam-gc
reviewed
Aug 13, 2020
packages-exp/auth-exp/src/platform_browser/persistence/browser.ts
Outdated
Show resolved
Hide resolved
Binary Size ReportAffected SDKsNo changes between base commit (c1e9229) and head commit (4fc04e9). Test Logs
|
avolkovi
force-pushed
the
avolkovi/persistence-events
branch
4 times, most recently
from
570191b to
73aec54
Compare
avolkovi
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
sam-gc
reviewed
Aug 25, 2020
|
|
||
| it('should update tokens if they have changed', async () => { | ||
| const userObj = user.toJSON(); | ||
| (userObj['stsTokenManager'] as any)['accessToken'] = 'new-access-token'; |
There was a problem hiding this comment.
Have you run this using yarn test ? This should blow up the linter step
There was a problem hiding this comment.
seems to pass somehow....
avolkovi
force-pushed
the
avolkovi/persistence-events
branch
from
73aec54 to
6ff492c
Compare
avolkovi
force-pushed
the
avolkovi/persistence-events
branch
from
6ff492c to
d13b99c
Compare
avolkovi
commented
Aug 25, 2020
sam-gc
approved these changes
Aug 25, 2020
packages-exp/auth-exp/src/platform_browser/persistence/indexed_db.ts
Outdated
Show resolved
Hide resolved
packages-exp/auth-exp/src/platform_browser/persistence/indexed_db.ts
Outdated
Show resolved
Hide resolved
| await new Promise(resolve => setTimeout(resolve, 100)); | ||
|
|
||
| expect(callback).not.to.have.been.called; | ||
| (persistence as any)['pendingWrites'] = 0; |
There was a problem hiding this comment.
This should also break the inter
There was a problem hiding this comment.
see above, seems to work for some reason
packages-exp/auth-exp/src/platform_browser/persistence/indexed_db.ts
Outdated
Show resolved
Hide resolved
packages-exp/auth-exp/src/platform_browser/persistence/local_storage.ts
Outdated
Show resolved
Hide resolved
packages-exp/auth-exp/src/platform_browser/persistence/local_storage.ts
Outdated
Show resolved
Hide resolved
sam-gc
pushed a commit
that referenced
this pull request
Sep 1, 2020
* Implement cross-window browser events for auth-next * Split out local & session storage * Add persistence events to indexed DB * Add some tests & fix a couple issues with local storage events * Add tests for AuthImpl._onStorageEvent and fix getIdToken to trigger correctly * Merge conflicts * PR feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.