Skip to content

Tree-Shake EventManager #3640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Aug 27, 2020
Merged

Tree-Shake EventManager #3640

merged 31 commits into from
Aug 27, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Aug 17, 2020

This sits between #3561 (Tree-Shake SyncEngine) and Tree-Shake RemoteStore (#3568) and removes more View handling from clients that don't use snapshot listens. The only regression (in terms of size) is that onSnapshotsInSync now pulls in all of Watch, which would only negatively affect users that use onSnapshotsInSync without other queries.

Slightly smaller diff with: #3640 (but once again much easier to review in IntelliJ)

@changeset-bot
Copy link

changeset-bot bot commented Aug 17, 2020

💥 No Changeset

Latest commit: 44223f9

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@schmidt-sebastian schmidt-sebastian changed the base branch from master to mrschmidt/optionalviews August 17, 2020 13:42
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 17, 2020

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (d7b5d2a) Head (efc6e6c) Diff
    browser 249 kB 249 kB -46 B (-0.0%)
    esm2017 195 kB 196 kB +130 B (+0.1%)
    main 478 kB 479 kB +850 B (+0.2%)
    module 246 kB 246 kB -46 B (-0.0%)
    react-native 196 kB 196 kB +130 B (+0.1%)
  • @firebase/firestore/exp

    Type Base (d7b5d2a) Head (efc6e6c) Diff
    browser 189 kB 189 kB +129 B (+0.1%)
    main 471 kB 471 kB +826 B (+0.2%)
    module 189 kB 189 kB +129 B (+0.1%)
    react-native 189 kB 189 kB +129 B (+0.1%)
  • @firebase/firestore/memory

    Type Base (d7b5d2a) Head (efc6e6c) Diff
    browser 186 kB 186 kB -46 B (-0.0%)
    esm2017 147 kB 147 kB +130 B (+0.1%)
    main 352 kB 353 kB +850 B (+0.2%)
    module 184 kB 184 kB -46 B (-0.0%)
    react-native 147 kB 147 kB +130 B (+0.1%)
  • firebase

    Type Base (d7b5d2a) Head (efc6e6c) Diff
    firebase-firestore.js 287 kB 287 kB -101 B (-0.0%)
    firebase-firestore.memory.js 227 kB 226 kB -101 B (-0.0%)
    firebase.js 822 kB 822 kB -101 B (-0.0%)

Test Logs

@wu-hui wu-hui assigned schmidt-sebastian and unassigned wu-hui Aug 18, 2020
@schmidt-sebastian schmidt-sebastian changed the base branch from mrschmidt/optionalviews to master August 27, 2020 18:58
@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

@firebase/app-exp

  • SDK_VERSION

    Size

    Type Base (7f52b3c) Head (1b391cb) Diff
    size 2.58 kB 2.63 kB +54 B (+2.1%)
    size_with_ext_deps 3.99 kB 4.05 kB +54 B (+1.4%)

    Dependencies

    Type Base (7f52b3c) Head (1b391cb) Diff
    variables
    Click to show 21 depsERRORS
    ERROR_FACTORY
    PLATFORM_LOG_STRING
    SDK_VERSION
    _apps
    _components
    logger
    name$1
    name$2
    name$3
    name$4
    name$5
    name$6
    name$7
    name$8
    name$9
    name$a
    name$b
    name$c
    version
    version$1
    Click to show 22 depsERRORS
    ERROR_FACTORY
    PLATFORM_LOG_STRING
    SDK_VERSION
    _apps
    _components
    logger
    name$1
    name$2
    name$3
    name$4
    name$5
    name$6
    name$7
    name$8
    name$9
    name$a
    name$b
    name$c
    name$d
    version
    version$1
    + name$d
  • _DEFAULT_ENTRY_NAME

    Size

    Type Base (7f52b3c) Head (1b391cb) Diff
    size ? 2.63 kB ? (?)
    size_with_ext_deps ? 4.05 kB ? (?)

    Dependencies

    Type Base (7f52b3c) Head (1b391cb) Diff
    functions ? _addComponent
    _registerComponent
    isVersionServiceProvider
    registerCoreComponents
    registerVersion
    ?
    classes ? PlatformLoggerService ?
    variables ?
    Click to show 21 depsERRORS
    ERROR_FACTORY
    PLATFORM_LOG_STRING
    _DEFAULT_ENTRY_NAME
    _apps
    _components
    logger
    name$1
    name$2
    name$3
    name$4
    name$5
    name$6
    name$7
    name$8
    name$9
    name$a
    name$b
    name$c
    name$d
    version
    ?

    External Dependencies

    Module Base (7f52b3c) Head (1b391cb) Diff
    @firebase/logger ? Logger ?
    @firebase/util ? ErrorFactory ?
    @firebase/component ? Component ?
  • _addComponent

    Size

    Type Base (7f52b3c) Head (1b391cb) Diff
    size 2.55 kB 2.61 kB +54 B (+2.1%)
    size_with_ext_deps 3.97 kB 4.02 kB +54 B (+1.4%)

    Dependencies

    Type Base (7f52b3c) Head (1b391cb) Diff
    variables
    Click to show 19 depsERRORS
    ERROR_FACTORY
    PLATFORM_LOG_STRING
    _apps
    _components
    logger
    name$1
    name$2
    name$3
    name$4
    name$5
    name$6
    name$7
    name$8
    name$9
    name$a
    name$b
    name$c
    version
    Click to show 20 depsERRORS
    ERROR_FACTORY
    PLATFORM_LOG_STRING
    _apps
    _components
    logger
    name$1
    name$2
    name$3
    name$4
    name$5
    name$6
    name$7
    name$8
    name$9
    name$a
    name$b
    name$c
    name$d
    version
    + name$d
  • _addOrOverwriteComponent

    Size

    Type Base (7f52b3c) Head (1b391cb) Diff
    size 2.62 kB 2.67 kB +54 B (+2.1%)
    size_with_ext_deps 4.04 kB 4.09 kB +54 B (+1.3%)

    Dependencies

    Type Base (7f52b3c) Head (1b391cb) Diff
    variables
    Click to show 19 depsERRORS
    ERROR_FACTORY
    PLATFORM_LOG_STRING
    _apps
    _components
    logger
    name$1
    name$2
    name$3
    name$4
    name$5
    name$6
    name$7
    name$8
    name$9
    name$a
    name$b
    name$c
    version
    Click to show 20 depsERRORS
    ERROR_FACTORY
    PLATFORM_LOG_STRING
    _apps
    _components
    logger
    name$1
    name$2
    name$3
    name$4
    name$5
    name$6
    name$7
    name$8
    name$9
    name$a
    name$b
    name$c
    name$d
    version
    + name$d
  • _apps

    Size

    Type Base (7f52b3c) Head (1b391cb) Diff
    size 2.55 kB 2.60 kB +54 B (+2.1%)
    size_with_ext_deps 3.96 kB 4.02 kB +54 B (+1.4%)

    Dependencies

    Type Base (7f52b3c) Head (1b391cb) Diff
    variables
    Click to show 19 depsERRORS
    ERROR_FACTORY
    PLATFORM_LOG_STRING
    _apps
    _components
    logger
    name$1
    name$2
    name$3
    name$4
    name$5
    name$6
    name$7
    name$8
    name$9
    name$a
    name$b
    name$c
    version
    Click to show 20 depsERRORS
    ERROR_FACTORY
    PLATFORM_LOG_STRING
    _apps
    _components
    logger
    name$1
    name$2
    name$3
    name$4
    name$5
    name$6
    name$7
    name$8
    name$9
    name$a
    name$b
    name$c
    name$d
    version
    + name$d
  • _clearComponents

    Size

    Type Base (7f52b3c) Head (1b391cb) Diff
    size 2.58 kB 2.63 kB +54 B (+2.1%)
    size_with_ext_deps 4.00 kB 4.05 kB +54 B (+1.4%)

    Dependencies

    Type Base (7f52b3c) Head (1b391cb) Diff
    variables
    Click to show 19 depsERRORS
    ERROR_FACTORY
    PLATFORM_LOG_STRING
    _apps
    _components
    logger
    name$1
    name$2
    name$3
    name$4
    name$5
    name$6
    name$7
    name$8
    name$9
    name$a
    name$b
    name$c
    version
    Click to show 20 depsERRORS
    ERROR_FACTORY
    PLATFORM_LOG_STRING
    _apps
    _components
    logger
    name$1
    name$2
    name$3
    name$4
    name$5
    name$6
    name$7
    name$8
    name$9
    name$a
    name$b
    name$c
    name$d
    version
    + name$d
  • _components

    Size

    Type Base (7f52b3c) Head (1b391cb) Diff
    size 2.55 kB 2.61 kB +54 B (+2.1%)
    size_with_ext_deps 3.97 kB 4.02 kB +54 B (+1.4%)

    Dependencies

    Type Base (7f52b3c) Head (1b391cb) Diff
    variables
    Click to show 19 depsERRORS
    ERROR_FACTORY
    PLATFORM_LOG_STRING
    _apps
    _components
    logger
    name$1
    name$2
    name$3
    name$4
    name$5
    name$6
    name$7
    name$8
    name$9
    name$a
    name$b
    name$c
    version
    Click to show 20 depsERRORS
    ERROR_FACTORY
    PLATFORM_LOG_STRING
    _apps
    _components
    logger
    name$1
    name$2
    name$3
    name$4
    name$5
    name$6
    name$7
    name$8
    name$9
    name$a
    name$b
    name$c
    name$d
    version
    + name$d
  • _getProvider

    Size

    Type Base (7f52b3c) Head (1b391cb) Diff
    size 2.60 kB 2.66 kB +54 B (+2.1%)
    size_with_ext_deps 4.02 kB 4.07 kB +54 B (+1.3%)

    Dependencies

    Type Base (7f52b3c) Head (1b391cb) Diff
    variables
    Click to show 19 depsERRORS
    ERROR_FACTORY
    PLATFORM_LOG_STRING
    _apps
    _components
    logger
    name$1
    name$2
    name$3
    name$4
    name$5
    name$6
    name$7
    name$8
    name$9
    name$a
    name$b
    name$c
    version
    Click to show 20 depsERRORS
    ERROR_FACTORY
    PLATFORM_LOG_STRING
    _apps
    _components
    logger
    name$1
    name$2
    name$3
    name$4
    name$5
    name$6
    name$7
    name$8
    name$9
    name$a
    name$b
    name$c
    name$d
    version
    + name$d
  • _registerComponent

    Size

    Type Base (7f52b3c) Head (1b391cb) Diff
    size 2.56 kB 2.61 kB +54 B (+2.1%)
    size_with_ext_deps 3.97 kB 4.03 kB +54 B (+1.4%)

    Dependencies

    Type Base (7f52b3c) Head (1b391cb) Diff
    variables
    Click to show 19 depsERRORS
    ERROR_FACTORY
    PLATFORM_LOG_STRING
    _apps
    _components
    logger
    name$1
    name$2
    name$3
    name$4
    name$5
    name$6
    name$7
    name$8
    name$9
    name$a
    name$b
    name$c
    version
    Click to show 20 depsERRORS
    ERROR_FACTORY
    PLATFORM_LOG_STRING
    _apps
    _components
    logger
    name$1
    name$2
    name$3
    name$4
    name$5
    name$6
    name$7
    name$8
    name$9
    name$a
    name$b
    name$c
    name$d
    version
    + name$d
  • _removeServiceInstance

    Size

    Type Base (7f52b3c) Head (1b391cb) Diff
    size 2.68 kB 2.73 kB +54 B (+2.0%)
    size_with_ext_deps 4.09 kB 4.15 kB +54 B (+1.3%)

    Dependencies

    Type Base (7f52b3c) Head (1b391cb) Diff
    variables
    Click to show 20 depsDEFAULT_ENTRY_NAME
    ERRORS
    ERROR_FACTORY
    PLATFORM_LOG_STRING
    _apps
    _components
    logger
    name$1
    name$2
    name$3
    name$4
    name$5
    name$6
    name$7
    name$8
    name$9
    name$a
    name$b
    name$c
    version
    Click to show 21 depsDEFAULT_ENTRY_NAME
    ERRORS
    ERROR_FACTORY
    PLATFORM_LOG_STRING
    _apps
    _components
    logger
    name$1
    name$2
    name$3
    name$4
    name$5
    name$6
    name$7
    name$8
    name$9
    name$a
    name$b
    name$c
    name$d
    version
    + name$d
  • deleteApp

    Size

    Type Base (7f52b3c) Head (1b391cb) Diff
    size 2.69 kB 2.75 kB +54 B (+2.0%)
    size_with_ext_deps 4.11 kB 4.16 kB +54 B (+1.3%)

    Dependencies

    Type Base (7f52b3c) Head (1b391cb) Diff
    variables
    Click to show 19 depsERRORS
    ERROR_FACTORY
    PLATFORM_LOG_STRING
    _apps
    _components
    logger
    name$1
    name$2
    name$3
    name$4
    name$5
    name$6
    name$7
    name$8
    name$9
    name$a
    name$b
    name$c
    version
    Click to show 20 depsERRORS
    ERROR_FACTORY
    PLATFORM_LOG_STRING
    _apps
    _components
    logger
    name$1
    name$2
    name$3
    name$4
    name$5
    name$6
    name$7
    name$8
    name$9
    name$a
    name$b
    name$c
    name$d
    version
    + name$d
  • getApp

    Size

    Type Base (7f52b3c) Head (1b391cb) Diff
    size 2.65 kB 2.71 kB +54 B (+2.0%)
    size_with_ext_deps 5.34 kB 5.39 kB +54 B (+1.0%)

    Dependencies

    Type Base (7f52b3c) Head (1b391cb) Diff
    variables
    Click to show 20 depsDEFAULT_ENTRY_NAME
    ERRORS
    ERROR_FACTORY
    PLATFORM_LOG_STRING
    _apps
    _components
    logger
    name$1
    name$2
    name$3
    name$4
    name$5
    name$6
    name$7
    name$8
    name$9
    name$a
    name$b
    name$c
    version
    Click to show 21 depsDEFAULT_ENTRY_NAME
    ERRORS
    ERROR_FACTORY
    PLATFORM_LOG_STRING
    _apps
    _components
    logger
    name$1
    name$2
    name$3
    name$4
    name$5
    name$6
    name$7
    name$8
    name$9
    name$a
    name$b
    name$c
    name$d
    version
    + name$d
  • getApps

    Size

    Type Base (7f52b3c) Head (1b391cb) Diff
    size 2.59 kB 2.64 kB +54 B (+2.1%)
    size_with_ext_deps 4.01 kB 4.06 kB +54 B (+1.3%)

    Dependencies

    Type Base (7f52b3c) Head (1b391cb) Diff
    variables
    Click to show 19 depsERRORS
    ERROR_FACTORY
    PLATFORM_LOG_STRING
    _apps
    _components
    logger
    name$1
    name$2
    name$3
    name$4
    name$5
    name$6
    name$7
    name$8
    name$9
    name$a
    name$b
    name$c
    version
    Click to show 20 depsERRORS
    ERROR_FACTORY
    PLATFORM_LOG_STRING
    _apps
    _components
    logger
    name$1
    name$2
    name$3
    name$4
    name$5
    name$6
    name$7
    name$8
    name$9
    name$a
    name$b
    name$c
    name$d
    version
    + name$d
  • initializeApp

    Size

    Type Base (7f52b3c) Head (1b391cb) Diff
    size 3.64 kB 3.69 kB +54 B (+1.5%)
    size_with_ext_deps 9.00 kB 9.05 kB +54 B (+0.6%)

    Dependencies

    Type Base (7f52b3c) Head (1b391cb) Diff
    variables
    Click to show 20 depsDEFAULT_ENTRY_NAME
    ERRORS
    ERROR_FACTORY
    PLATFORM_LOG_STRING
    _apps
    _components
    logger
    name$1
    name$2
    name$3
    name$4
    name$5
    name$6
    name$7
    name$8
    name$9
    name$a
    name$b
    name$c
    version
    Click to show 21 depsDEFAULT_ENTRY_NAME
    ERRORS
    ERROR_FACTORY
    PLATFORM_LOG_STRING
    _apps
    _components
    logger
    name$1
    name$2
    name$3
    name$4
    name$5
    name$6
    name$7
    name$8
    name$9
    name$a
    name$b
    name$c
    name$d
    version
    + name$d
  • onLog

    Size

    Type Base (7f52b3c) Head (1b391cb) Diff
    size 2.68 kB 2.74 kB +54 B (+2.0%)
    size_with_ext_deps 5.89 kB 5.95 kB +54 B (+0.9%)

    Dependencies

    Type Base (7f52b3c) Head (1b391cb) Diff
    variables
    Click to show 19 depsERRORS
    ERROR_FACTORY
    PLATFORM_LOG_STRING
    _apps
    _components
    logger
    name$1
    name$2
    name$3
    name$4
    name$5
    name$6
    name$7
    name$8
    name$9
    name$a
    name$b
    name$c
    version
    Click to show 20 depsERRORS
    ERROR_FACTORY
    PLATFORM_LOG_STRING
    _apps
    _components
    logger
    name$1
    name$2
    name$3
    name$4
    name$5
    name$6
    name$7
    name$8
    name$9
    name$a
    name$b
    name$c
    name$d
    version
    + name$d
  • registerVersion

    Size

    Type Base (7f52b3c) Head (1b391cb) Diff
    size 2.56 kB 2.61 kB +54 B (+2.1%)
    size_with_ext_deps 3.97 kB 4.03 kB +54 B (+1.4%)

    Dependencies

    Type Base (7f52b3c) Head (1b391cb) Diff
    variables
    Click to show 19 depsERRORS
    ERROR_FACTORY
    PLATFORM_LOG_STRING
    _apps
    _components
    logger
    name$1
    name$2
    name$3
    name$4
    name$5
    name$6
    name$7
    name$8
    name$9
    name$a
    name$b
    name$c
    version
    Click to show 20 depsERRORS
    ERROR_FACTORY
    PLATFORM_LOG_STRING
    _apps
    _components
    logger
    name$1
    name$2
    name$3
    name$4
    name$5
    name$6
    name$7
    name$8
    name$9
    name$a
    name$b
    name$c
    name$d
    version
    + name$d
  • setLogLevel

    Size

    Type Base (7f52b3c) Head (1b391cb) Diff
    size 2.59 kB 2.64 kB +54 B (+2.1%)
    size_with_ext_deps 4.06 kB 4.11 kB +54 B (+1.3%)

    Dependencies

    Type Base (7f52b3c) Head (1b391cb) Diff
    variables
    Click to show 19 depsERRORS
    ERROR_FACTORY
    PLATFORM_LOG_STRING
    _apps
    _components
    logger
    name$1
    name$2
    name$3
    name$4
    name$5
    name$6
    name$7
    name$8
    name$9
    name$a
    name$b
    name$c
    version
    Click to show 20 depsERRORS
    ERROR_FACTORY
    PLATFORM_LOG_STRING
    _apps
    _components
    logger
    name$1
    name$2
    name$3
    name$4
    name$5
    name$6
    name$7
    name$8
    name$9
    name$a
    name$b
    name$c
    name$d
    version
    + name$d

@firebase/functions-exp

  • getFunctions

    Size

    Type Base (7f52b3c) Head (1b391cb) Diff
    size_with_ext_deps 5.66 kB 5.71 kB +54 B (+1.0%)
  • httpsCallable

    Size

    Type Base (7f52b3c) Head (1b391cb) Diff
    size_with_ext_deps 9.74 kB 9.79 kB +56 B (+0.6%)
  • useFunctionsEmulator

    Size

    Type Base (7f52b3c) Head (1b391cb) Diff
    size_with_ext_deps 5.59 kB 5.65 kB +54 B (+1.0%)

Test Logs

@schmidt-sebastian schmidt-sebastian merged commit b0a75ac into master Aug 27, 2020
@firebase firebase locked and limited conversation to collaborators Sep 27, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/eventmanager branch November 9, 2020 22:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants