-
Notifications
You must be signed in to change notification settings - Fork 945
Tree-Shake EventManager #3640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tree-Shake EventManager #3640
Conversation
💥 No ChangesetLatest commit: 44223f9 Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
Binary Size ReportAffected SDKs
Test Logs
|
…-js-sdk into mrschmidt/eventmanager
Size Analysis ReportAffected Products
|
Type | Base (7f52b3c) | Head (1b391cb) | Diff |
---|---|---|---|
size | 2.58 kB | 2.63 kB | +54 B (+2.1%) |
size_with_ext_deps | 3.99 kB | 4.05 kB | +54 B (+1.4%) |
Dependencies
Type | Base (7f52b3c) | Head (1b391cb) | Diff |
---|---|---|---|
variables | Click to show 21 depsERRORS ERROR_FACTORY PLATFORM_LOG_STRING SDK_VERSION _apps _components logger name$1 name$2 name$3 name$4 name$5 name$6 name$7 name$8 name$9 name$a name$b name$c version version$1 |
Click to show 22 depsERRORS ERROR_FACTORY PLATFORM_LOG_STRING SDK_VERSION _apps _components logger name$1 name$2 name$3 name$4 name$5 name$6 name$7 name$8 name$9 name$a name$b name$c name$d version version$1 |
+ name$d |
_DEFAULT_ENTRY_NAME
Size
Type | Base (7f52b3c) | Head (1b391cb) | Diff |
---|---|---|---|
size | ? | 2.63 kB | ? (?) |
size_with_ext_deps | ? | 4.05 kB | ? (?) |
Dependencies
Type | Base (7f52b3c) | Head (1b391cb) | Diff |
---|---|---|---|
functions | ? | _addComponent _registerComponent isVersionServiceProvider registerCoreComponents registerVersion |
? |
classes | ? | PlatformLoggerService |
? |
variables | ? | Click to show 21 depsERRORS ERROR_FACTORY PLATFORM_LOG_STRING _DEFAULT_ENTRY_NAME _apps _components logger name$1 name$2 name$3 name$4 name$5 name$6 name$7 name$8 name$9 name$a name$b name$c name$d version |
? |
External Dependencies
Module | Base (7f52b3c) | Head (1b391cb) | Diff |
---|---|---|---|
@firebase/logger |
? | Logger |
? |
@firebase/util |
? | ErrorFactory |
? |
@firebase/component |
? | Component |
? |
_addComponent
Size
Type | Base (7f52b3c) | Head (1b391cb) | Diff |
---|---|---|---|
size | 2.55 kB | 2.61 kB | +54 B (+2.1%) |
size_with_ext_deps | 3.97 kB | 4.02 kB | +54 B (+1.4%) |
Dependencies
Type | Base (7f52b3c) | Head (1b391cb) | Diff |
---|---|---|---|
variables | Click to show 19 depsERRORS ERROR_FACTORY PLATFORM_LOG_STRING _apps _components logger name$1 name$2 name$3 name$4 name$5 name$6 name$7 name$8 name$9 name$a name$b name$c version |
Click to show 20 depsERRORS ERROR_FACTORY PLATFORM_LOG_STRING _apps _components logger name$1 name$2 name$3 name$4 name$5 name$6 name$7 name$8 name$9 name$a name$b name$c name$d version |
+ name$d |
_addOrOverwriteComponent
Size
Type | Base (7f52b3c) | Head (1b391cb) | Diff |
---|---|---|---|
size | 2.62 kB | 2.67 kB | +54 B (+2.1%) |
size_with_ext_deps | 4.04 kB | 4.09 kB | +54 B (+1.3%) |
Dependencies
Type | Base (7f52b3c) | Head (1b391cb) | Diff |
---|---|---|---|
variables | Click to show 19 depsERRORS ERROR_FACTORY PLATFORM_LOG_STRING _apps _components logger name$1 name$2 name$3 name$4 name$5 name$6 name$7 name$8 name$9 name$a name$b name$c version |
Click to show 20 depsERRORS ERROR_FACTORY PLATFORM_LOG_STRING _apps _components logger name$1 name$2 name$3 name$4 name$5 name$6 name$7 name$8 name$9 name$a name$b name$c name$d version |
+ name$d |
_apps
Size
Type | Base (7f52b3c) | Head (1b391cb) | Diff |
---|---|---|---|
size | 2.55 kB | 2.60 kB | +54 B (+2.1%) |
size_with_ext_deps | 3.96 kB | 4.02 kB | +54 B (+1.4%) |
Dependencies
Type | Base (7f52b3c) | Head (1b391cb) | Diff |
---|---|---|---|
variables | Click to show 19 depsERRORS ERROR_FACTORY PLATFORM_LOG_STRING _apps _components logger name$1 name$2 name$3 name$4 name$5 name$6 name$7 name$8 name$9 name$a name$b name$c version |
Click to show 20 depsERRORS ERROR_FACTORY PLATFORM_LOG_STRING _apps _components logger name$1 name$2 name$3 name$4 name$5 name$6 name$7 name$8 name$9 name$a name$b name$c name$d version |
+ name$d |
_clearComponents
Size
Type | Base (7f52b3c) | Head (1b391cb) | Diff |
---|---|---|---|
size | 2.58 kB | 2.63 kB | +54 B (+2.1%) |
size_with_ext_deps | 4.00 kB | 4.05 kB | +54 B (+1.4%) |
Dependencies
Type | Base (7f52b3c) | Head (1b391cb) | Diff |
---|---|---|---|
variables | Click to show 19 depsERRORS ERROR_FACTORY PLATFORM_LOG_STRING _apps _components logger name$1 name$2 name$3 name$4 name$5 name$6 name$7 name$8 name$9 name$a name$b name$c version |
Click to show 20 depsERRORS ERROR_FACTORY PLATFORM_LOG_STRING _apps _components logger name$1 name$2 name$3 name$4 name$5 name$6 name$7 name$8 name$9 name$a name$b name$c name$d version |
+ name$d |
_components
Size
Type | Base (7f52b3c) | Head (1b391cb) | Diff |
---|---|---|---|
size | 2.55 kB | 2.61 kB | +54 B (+2.1%) |
size_with_ext_deps | 3.97 kB | 4.02 kB | +54 B (+1.4%) |
Dependencies
Type | Base (7f52b3c) | Head (1b391cb) | Diff |
---|---|---|---|
variables | Click to show 19 depsERRORS ERROR_FACTORY PLATFORM_LOG_STRING _apps _components logger name$1 name$2 name$3 name$4 name$5 name$6 name$7 name$8 name$9 name$a name$b name$c version |
Click to show 20 depsERRORS ERROR_FACTORY PLATFORM_LOG_STRING _apps _components logger name$1 name$2 name$3 name$4 name$5 name$6 name$7 name$8 name$9 name$a name$b name$c name$d version |
+ name$d |
_getProvider
Size
Type | Base (7f52b3c) | Head (1b391cb) | Diff |
---|---|---|---|
size | 2.60 kB | 2.66 kB | +54 B (+2.1%) |
size_with_ext_deps | 4.02 kB | 4.07 kB | +54 B (+1.3%) |
Dependencies
Type | Base (7f52b3c) | Head (1b391cb) | Diff |
---|---|---|---|
variables | Click to show 19 depsERRORS ERROR_FACTORY PLATFORM_LOG_STRING _apps _components logger name$1 name$2 name$3 name$4 name$5 name$6 name$7 name$8 name$9 name$a name$b name$c version |
Click to show 20 depsERRORS ERROR_FACTORY PLATFORM_LOG_STRING _apps _components logger name$1 name$2 name$3 name$4 name$5 name$6 name$7 name$8 name$9 name$a name$b name$c name$d version |
+ name$d |
_registerComponent
Size
Type | Base (7f52b3c) | Head (1b391cb) | Diff |
---|---|---|---|
size | 2.56 kB | 2.61 kB | +54 B (+2.1%) |
size_with_ext_deps | 3.97 kB | 4.03 kB | +54 B (+1.4%) |
Dependencies
Type | Base (7f52b3c) | Head (1b391cb) | Diff |
---|---|---|---|
variables | Click to show 19 depsERRORS ERROR_FACTORY PLATFORM_LOG_STRING _apps _components logger name$1 name$2 name$3 name$4 name$5 name$6 name$7 name$8 name$9 name$a name$b name$c version |
Click to show 20 depsERRORS ERROR_FACTORY PLATFORM_LOG_STRING _apps _components logger name$1 name$2 name$3 name$4 name$5 name$6 name$7 name$8 name$9 name$a name$b name$c name$d version |
+ name$d |
_removeServiceInstance
Size
Type | Base (7f52b3c) | Head (1b391cb) | Diff |
---|---|---|---|
size | 2.68 kB | 2.73 kB | +54 B (+2.0%) |
size_with_ext_deps | 4.09 kB | 4.15 kB | +54 B (+1.3%) |
Dependencies
Type | Base (7f52b3c) | Head (1b391cb) | Diff |
---|---|---|---|
variables | Click to show 20 depsDEFAULT_ENTRY_NAME ERRORS ERROR_FACTORY PLATFORM_LOG_STRING _apps _components logger name$1 name$2 name$3 name$4 name$5 name$6 name$7 name$8 name$9 name$a name$b name$c version |
Click to show 21 depsDEFAULT_ENTRY_NAME ERRORS ERROR_FACTORY PLATFORM_LOG_STRING _apps _components logger name$1 name$2 name$3 name$4 name$5 name$6 name$7 name$8 name$9 name$a name$b name$c name$d version |
+ name$d |
deleteApp
Size
Type | Base (7f52b3c) | Head (1b391cb) | Diff |
---|---|---|---|
size | 2.69 kB | 2.75 kB | +54 B (+2.0%) |
size_with_ext_deps | 4.11 kB | 4.16 kB | +54 B (+1.3%) |
Dependencies
Type | Base (7f52b3c) | Head (1b391cb) | Diff |
---|---|---|---|
variables | Click to show 19 depsERRORS ERROR_FACTORY PLATFORM_LOG_STRING _apps _components logger name$1 name$2 name$3 name$4 name$5 name$6 name$7 name$8 name$9 name$a name$b name$c version |
Click to show 20 depsERRORS ERROR_FACTORY PLATFORM_LOG_STRING _apps _components logger name$1 name$2 name$3 name$4 name$5 name$6 name$7 name$8 name$9 name$a name$b name$c name$d version |
+ name$d |
getApp
Size
Type | Base (7f52b3c) | Head (1b391cb) | Diff |
---|---|---|---|
size | 2.65 kB | 2.71 kB | +54 B (+2.0%) |
size_with_ext_deps | 5.34 kB | 5.39 kB | +54 B (+1.0%) |
Dependencies
Type | Base (7f52b3c) | Head (1b391cb) | Diff |
---|---|---|---|
variables | Click to show 20 depsDEFAULT_ENTRY_NAME ERRORS ERROR_FACTORY PLATFORM_LOG_STRING _apps _components logger name$1 name$2 name$3 name$4 name$5 name$6 name$7 name$8 name$9 name$a name$b name$c version |
Click to show 21 depsDEFAULT_ENTRY_NAME ERRORS ERROR_FACTORY PLATFORM_LOG_STRING _apps _components logger name$1 name$2 name$3 name$4 name$5 name$6 name$7 name$8 name$9 name$a name$b name$c name$d version |
+ name$d |
getApps
Size
Type | Base (7f52b3c) | Head (1b391cb) | Diff |
---|---|---|---|
size | 2.59 kB | 2.64 kB | +54 B (+2.1%) |
size_with_ext_deps | 4.01 kB | 4.06 kB | +54 B (+1.3%) |
Dependencies
Type | Base (7f52b3c) | Head (1b391cb) | Diff |
---|---|---|---|
variables | Click to show 19 depsERRORS ERROR_FACTORY PLATFORM_LOG_STRING _apps _components logger name$1 name$2 name$3 name$4 name$5 name$6 name$7 name$8 name$9 name$a name$b name$c version |
Click to show 20 depsERRORS ERROR_FACTORY PLATFORM_LOG_STRING _apps _components logger name$1 name$2 name$3 name$4 name$5 name$6 name$7 name$8 name$9 name$a name$b name$c name$d version |
+ name$d |
initializeApp
Size
Type | Base (7f52b3c) | Head (1b391cb) | Diff |
---|---|---|---|
size | 3.64 kB | 3.69 kB | +54 B (+1.5%) |
size_with_ext_deps | 9.00 kB | 9.05 kB | +54 B (+0.6%) |
Dependencies
Type | Base (7f52b3c) | Head (1b391cb) | Diff |
---|---|---|---|
variables | Click to show 20 depsDEFAULT_ENTRY_NAME ERRORS ERROR_FACTORY PLATFORM_LOG_STRING _apps _components logger name$1 name$2 name$3 name$4 name$5 name$6 name$7 name$8 name$9 name$a name$b name$c version |
Click to show 21 depsDEFAULT_ENTRY_NAME ERRORS ERROR_FACTORY PLATFORM_LOG_STRING _apps _components logger name$1 name$2 name$3 name$4 name$5 name$6 name$7 name$8 name$9 name$a name$b name$c name$d version |
+ name$d |
onLog
Size
Type | Base (7f52b3c) | Head (1b391cb) | Diff |
---|---|---|---|
size | 2.68 kB | 2.74 kB | +54 B (+2.0%) |
size_with_ext_deps | 5.89 kB | 5.95 kB | +54 B (+0.9%) |
Dependencies
Type | Base (7f52b3c) | Head (1b391cb) | Diff |
---|---|---|---|
variables | Click to show 19 depsERRORS ERROR_FACTORY PLATFORM_LOG_STRING _apps _components logger name$1 name$2 name$3 name$4 name$5 name$6 name$7 name$8 name$9 name$a name$b name$c version |
Click to show 20 depsERRORS ERROR_FACTORY PLATFORM_LOG_STRING _apps _components logger name$1 name$2 name$3 name$4 name$5 name$6 name$7 name$8 name$9 name$a name$b name$c name$d version |
+ name$d |
registerVersion
Size
Type | Base (7f52b3c) | Head (1b391cb) | Diff |
---|---|---|---|
size | 2.56 kB | 2.61 kB | +54 B (+2.1%) |
size_with_ext_deps | 3.97 kB | 4.03 kB | +54 B (+1.4%) |
Dependencies
Type | Base (7f52b3c) | Head (1b391cb) | Diff |
---|---|---|---|
variables | Click to show 19 depsERRORS ERROR_FACTORY PLATFORM_LOG_STRING _apps _components logger name$1 name$2 name$3 name$4 name$5 name$6 name$7 name$8 name$9 name$a name$b name$c version |
Click to show 20 depsERRORS ERROR_FACTORY PLATFORM_LOG_STRING _apps _components logger name$1 name$2 name$3 name$4 name$5 name$6 name$7 name$8 name$9 name$a name$b name$c name$d version |
+ name$d |
setLogLevel
Size
Type | Base (7f52b3c) | Head (1b391cb) | Diff |
---|---|---|---|
size | 2.59 kB | 2.64 kB | +54 B (+2.1%) |
size_with_ext_deps | 4.06 kB | 4.11 kB | +54 B (+1.3%) |
Dependencies
Type | Base (7f52b3c) | Head (1b391cb) | Diff |
---|---|---|---|
variables | Click to show 19 depsERRORS ERROR_FACTORY PLATFORM_LOG_STRING _apps _components logger name$1 name$2 name$3 name$4 name$5 name$6 name$7 name$8 name$9 name$a name$b name$c version |
Click to show 20 depsERRORS ERROR_FACTORY PLATFORM_LOG_STRING _apps _components logger name$1 name$2 name$3 name$4 name$5 name$6 name$7 name$8 name$9 name$a name$b name$c name$d version |
+ name$d |
@firebase/functions-exp
-
getFunctions
Size
Type Base (7f52b3c) Head (1b391cb) Diff size_with_ext_deps 5.66 kB 5.71 kB +54 B (+1.0%) -
httpsCallable
Size
Type Base (7f52b3c) Head (1b391cb) Diff size_with_ext_deps 9.74 kB 9.79 kB +56 B (+0.6%) -
useFunctionsEmulator
Size
Type Base (7f52b3c) Head (1b391cb) Diff size_with_ext_deps 5.59 kB 5.65 kB +54 B (+1.0%)
Test Logs
- Base (
7f52b3cb
): https://github.com/firebase/firebase-js-sdk/actions/runs/226808961 - Head (
1b391cb9
): https://github.com/firebase/firebase-js-sdk/actions/runs/227517118
This sits between #3561 (Tree-Shake SyncEngine) and Tree-Shake RemoteStore (#3568) and removes more View handling from clients that don't use snapshot listens. The only regression (in terms of size) is that
onSnapshotsInSync
now pulls in all of Watch, which would only negatively affect users that use onSnapshotsInSync without other queries.Slightly smaller diff with: #3640 (but once again much easier to review in IntelliJ)