Skip to content

Replace usage of Set<DocumentKey> with Set<path> #3652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

Since JavaScript Sets use reference equality for objects, we should not store DocumentKeys in Sets. Rather, we can use the string representation.

Fixes b/157233697

@changeset-bot
Copy link

changeset-bot bot commented Aug 18, 2020

💥 No Changeset

Latest commit: 1da7e02

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (8072624) Head (38517bc) Diff
    browser 249 kB 249 kB +179 B (+0.1%)
    esm2017 195 kB 195 kB +185 B (+0.1%)
    main 475 kB 475 kB +239 B (+0.1%)
    module 246 kB 246 kB +179 B (+0.1%)
    react-native 195 kB 196 kB +185 B (+0.1%)
  • @firebase/firestore/exp

    Type Base (8072624) Head (38517bc) Diff
    browser 189 kB 189 kB +191 B (+0.1%)
    main 468 kB 468 kB +239 B (+0.1%)
    module 189 kB 189 kB +191 B (+0.1%)
    react-native 189 kB 189 kB +191 B (+0.1%)
  • @firebase/firestore/lite

    Type Base (8072624) Head (38517bc) Diff
    browser 64.6 kB 64.7 kB +84 B (+0.1%)
    main 141 kB 141 kB +126 B (+0.1%)
    module 64.6 kB 64.7 kB +84 B (+0.1%)
    react-native 64.7 kB 64.8 kB +84 B (+0.1%)
  • @firebase/firestore/memory

    Type Base (8072624) Head (38517bc) Diff
    browser 187 kB 187 kB +178 B (+0.1%)
    esm2017 146 kB 147 kB +184 B (+0.1%)
    main 349 kB 349 kB +239 B (+0.1%)
    module 185 kB 185 kB +178 B (+0.1%)
    react-native 146 kB 147 kB +184 B (+0.1%)
  • firebase

    Type Base (8072624) Head (38517bc) Diff
    firebase-firestore.js 287 kB 287 kB +182 B (+0.1%)
    firebase-firestore.memory.js 227 kB 227 kB +181 B (+0.1%)
    firebase.js 822 kB 822 kB +182 B (+0.0%)

Test Logs

Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@schmidt-sebastian schmidt-sebastian merged commit 00ac9d2 into master Aug 18, 2020
@firebase firebase locked and limited conversation to collaborators Sep 18, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/noset branch November 9, 2020 22:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants