Skip to content

Show CI logs if run is longer than 1 hour #3665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 20, 2020
Merged

Show CI logs if run is longer than 1 hour #3665

merged 5 commits into from
Aug 20, 2020

Conversation

hsubox76
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Aug 19, 2020

💥 No Changeset

Latest commit: 5da9ac5

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 19, 2020

Binary Size Report

Affected SDKs

No changes between base commit (05f8002) and head commit (61e460f).

Test Logs

@@ -52,10 +57,14 @@ const argv = yargs.options({

await testProcess;
console.log('Success: ' + name);
appendFileSync(LOGFILE, stdout + '\n' + stderr, { encoding: 'utf8' });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will there be any race condition ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will absolutely be race conditions. I changed it to write multiple files.

@hsubox76 hsubox76 merged commit ccbcadc into master Aug 20, 2020
@hsubox76 hsubox76 deleted the ch-test-ci-fix branch September 15, 2020 16:44
@firebase firebase locked and limited conversation to collaborators Sep 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants