-
Notifications
You must be signed in to change notification settings - Fork 945
Show CI logs if run is longer than 1 hour #3665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💥 No ChangesetLatest commit: 5da9ac5 Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
Binary Size ReportAffected SDKsNo changes between base commit (05f8002) and head commit (61e460f). Test Logs
|
bb7fd9e
to
a8d0f10
Compare
scripts/run_tests_in_ci.js
Outdated
@@ -52,10 +57,14 @@ const argv = yargs.options({ | |||
|
|||
await testProcess; | |||
console.log('Success: ' + name); | |||
appendFileSync(LOGFILE, stdout + '\n' + stderr, { encoding: 'utf8' }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will there be any race condition ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There will absolutely be race conditions. I changed it to write multiple files.
No description provided.