Fix release build for firebase-exp/compat

packages-exp/app-compat/package.json

@@ -17,6 +17,7 @@
     "lint": "eslint -c .eslintrc.js '**/*.ts' --ignore-path '../../.gitignore'",
     "lint:fix": "eslint --fix -c .eslintrc.js '**/*.ts'  --ignore-path '../../.gitignore'",
     "build": "rollup -c",
+    "build:release": "rollup -c rollup.config.release.js",
     "build:deps": "lerna run --scope @firebase/app-compat --include-dependencies build",
     "dev": "rollup -c -w",
     "test": "run-p lint test:all",

packages-exp/app-compat/rollup.config.release.js

@@ -0,0 +1,121 @@
+/**
+ * @license
+ * Copyright 2018 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import typescriptPlugin from 'rollup-plugin-typescript2';
+import json from 'rollup-plugin-json';
+import typescript from 'typescript';
+import pkg from './package.json';
+import { importPathTransformer } from '../../scripts/exp/ts-transform-import-path';
+
+const deps = Object.keys(
+  Object.assign({}, pkg.peerDependencies, pkg.dependencies)
+);
+
+/**
+ * ES5 Builds
+ */
+const es5BuildPlugins = [
+  typescriptPlugin({
+    typescript,
+    clean: true,
+    abortOnError: false,
+    transformers: [importPathTransformer]
+  }),
+  json()
+];
+
+const es5Builds = [
+  {
+    input: 'src/index.ts',
+    output: [
+      { file: pkg.main, format: 'cjs', sourcemap: true },
+      { file: pkg.module, format: 'es', sourcemap: true }
+    ],
+    plugins: es5BuildPlugins,
+    external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
+    treeshake: {
+      moduleSideEffects: false
+    }
+  },
+  {
+    input: 'src/index.lite.ts',
+    output: {
+      file: pkg.lite,
+      format: 'es',
+      sourcemap: true
+    },
+    plugins: es5BuildPlugins,
+    external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
+    treeshake: {
+      moduleSideEffects: false
+    }
+  }
+];
+
+/**
+ * ES2017 Builds
+ */
+const es2017BuildPlugins = [
+  typescriptPlugin({
+    typescript,
+    clean: true,
+    abortOnError: false,
+    tsconfigOverride: {
+      compilerOptions: {
+        target: 'es2017'
+      }
+    },
+    transformers: [importPathTransformer]
+  }),
+  json({
+    preferConst: true
+  })
+];
+
+const es2017Builds = [
+  /**
+   *  Browser Builds
+   */
+  {
+    input: 'src/index.ts',
+    output: {
+      file: pkg.esm2017,
+      format: 'es',
+      sourcemap: true
+    },
+    plugins: es2017BuildPlugins,
+    external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
+    treeshake: {
+      moduleSideEffects: false
+    }
+  },
+  {
+    input: 'src/index.lite.ts',
+    output: {
+      file: pkg['lite-esm2017'],
+      format: 'es',
+      sourcemap: true
+    },
+    plugins: es2017BuildPlugins,
+    external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
+    treeshake: {
+      moduleSideEffects: false
+    }
+  }
+];
+
+export default [...es5Builds, ...es2017Builds];

packages-exp/firebase-exp/compat/rollup.config.release.js

@@ -0,0 +1,93 @@
+/**
+ * @license
+ * Copyright 2020 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { resolve } from 'path';
+import sourcemaps from 'rollup-plugin-sourcemaps';
+import rollupTypescriptPlugin from 'rollup-plugin-typescript2';
+import typescript from 'typescript';
+import json from 'rollup-plugin-json';
+import pkg from '../package.json';
+import compatPkg from './package.json';
+import appPkg from './app/package.json';
+
+const external = Object.keys(pkg.dependencies || {});
+
+const plugins = [sourcemaps(), json()];
+
+const typescriptPlugin = rollupTypescriptPlugin({
+  typescript,
+  tsconfigOverride: {
+    compilerOptions: {
+      declaration: false
+    }
+  }
+});
+
+/**
+ * Individual Component Builds
+ */
+const appBuilds = [
+  /**
+   * App Browser Builds
+   */
+  {
+    input: `${__dirname}/app/index.ts`,
+    output: [
+      {
+        file: resolve(__dirname, 'app', appPkg.main),
+        format: 'cjs',
+        sourcemap: true
+      },
+      {
+        file: resolve(__dirname, 'app', appPkg.module),
+        format: 'es',
+        sourcemap: true
+      }
+    ],
+    plugins: [...plugins, typescriptPlugin],
+    external
+  }
+];
+
+const componentBuilds = compatPkg.components
+  // The "app" component is treated differently because it doesn't depend on itself.
+  .filter(component => component !== 'app')
+  .map(component => {
+    const pkg = require(`${__dirname}/${component}/package.json`);
+    return [
+      {
+        input: `${__dirname}/${component}/index.ts`,
+        output: [
+          {
+            file: resolve(__dirname, component, pkg.main),
+            format: 'cjs',
+            sourcemap: true
+          },
+          {
+            file: resolve(__dirname, component, pkg.module),
+            format: 'es',
+            sourcemap: true
+          }
+        ],
+        plugins: [...plugins, typescriptPlugin],
+        external
+      }
+    ];
+  })
+  .reduce((a, b) => a.concat(b), []);
+
+export default [...appBuilds, ...componentBuilds];

packages-exp/firebase-exp/package.json

@@ -28,8 +28,9 @@
   },
   "scripts": {
     "build": "rollup -c && gulp firebase-js && yarn build:compat",
-    "build:release": "rollup -c rollup.config.release.js && gulp firebase-js && yarn build:compat",
+    "build:release": "rollup -c rollup.config.release.js && gulp firebase-js && yarn build:compat:release",
     "build:compat": "rollup -c compat/rollup.config.js",
+    "build:compat:release": "rollup -c compat/rollup.config.release.js",
     "dev": "rollup -c -w",
     "prepare": "yarn build:release",
     "test": "echo 'No test suite for firebase wrapper'",

packages-exp/firebase-exp/rollup.config.js

@@ -116,6 +116,9 @@ const componentBuilds = pkg.components
   .filter(component => component !== 'app')
   .map(component => {
     const pkg = require(`./${component}/package.json`);
+    // It is needed for handling sub modules, for example firestore/lite which should produce firebase-firestore-lite.js
+    // Otherwise, we will create a directory with '/' in the name.
+    const componentName = component.replace('/', '-');
     return [
       {
         input: `${component}/index.ts`,
@@ -136,7 +139,10 @@ const componentBuilds = pkg.components
       },
       {
         input: `${component}/index.ts`,
-        output: createUmdOutputConfig(`firebase-${component}.js`, component),
+        output: createUmdOutputConfig(
+          `firebase-${componentName}.js`,
+          componentName
+        ),
         plugins: [...plugins, typescriptPluginUMD, uglify()],
         external: ['@firebase/app-exp']
       }

scripts/exp/release.ts

@@ -135,10 +135,18 @@ async function buildPackages() {
     }
   );
 
-  // Build exp packages except for firebase-exp
+  // Build exp and compat packages except for firebase-exp
   await spawn(
     'yarn',
-    ['lerna', 'run', '--scope', '@firebase/*-exp', 'build:release'],
+    [
+      'lerna',
+      'run',
+      '--scope',
+      '@firebase/*-exp',
+      '--scope',
+      '@firebase/*-compat',
+      'build:release'
+    ],
     {
       cwd: projectRoot,
       stdio: 'inherit'
@@ -156,16 +164,6 @@ async function buildPackages() {
     }
   );
 
-  // Build compat packages
-  await spawn(
-    'yarn',
-    ['lerna', 'run', '--scope', '@firebase/*-compat', 'build'],
-    {
-      cwd: projectRoot,
-      stdio: 'inherit'
-    }
-  );
-
   // Build firebase-exp
   await spawn(
     'yarn',