Fix externals for packages/firebase builds #3729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Analysis ReportAffected ProductsNo changes between base commit (1bf0a3c) and head commit (25e3ba6). Test Logs
|
Feiyang1
suggested changes
Sep 2, 2020
packages/firebase/rollup.config.js
Outdated
| @@ -70,7 +70,8 @@ const plugins = [ | |||
| commonjs() | |||
| ]; | |||
|
|
|||
| const external = Object.keys(pkg.dependencies || {}); | |||
| const deps = [...Object.keys(pkg.dependencies || {}), 'tslib']; | |||
There was a problem hiding this comment.
You don't need to add tslib which is a not a direct dependency of firebase/firestore/memory, etc. We are good as long as the scoped packages e.g. @firebase/firestore/memory are excluded.
Feiyang1
approved these changes
Sep 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Externals should include tslib and use
startsWithpattern.