Skip to content

Run prettier on whole repo #3754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2020
Merged

Run prettier on whole repo #3754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdc3e6c
Run prettier on whole repo
hsubox76 Sep 9, 2020
9b0529f
Exclude packages/firestore/scripts
hsubox76 Sep 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# This file is pre-built and need not be formatted
packages/auth
packages/firebase/firebase*
packages/firestore/scripts
dist
9 changes: 4 additions & 5 deletions integration/messaging/test/test-send.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,14 +67,14 @@ describe('Starting Integration Test > Sending and Receiving ', function () {
}

TEST_DOMAINS.forEach(domain => {
describe(`Testing browser: ${assistantBrowser.getPrettyName()} : ${domain}`, function() {
before(async function() {
describe(`Testing browser: ${assistantBrowser.getPrettyName()} : ${domain}`, function () {
before(async function () {
globalWebDriver = createPermittedWebDriver(
/* browser= */ assistantBrowser.getId()
);
});

it('Background app can receive a {} empty message from sw', async function() {
it('Background app can receive a {} empty message from sw', async function () {
this.timeout(TIMEOUT_BACKGROUND_MESSAGE_TEST_UNIT_MILLISECONDS);

// Clearing the cache and db data by killing the previously instantiated driver. Note that
Expand Down Expand Up @@ -107,7 +107,7 @@ describe('Starting Integration Test > Sending and Receiving ', function () {
);
});

it('Background app can receive a {"data"} message frow sw', async function() {
it('Background app can receive a {"data"} message frow sw', async function () {
this.timeout(TIMEOUT_BACKGROUND_MESSAGE_TEST_UNIT_MILLISECONDS);

await seleniumAssistant.killWebDriver(globalWebDriver);
Expand Down Expand Up @@ -135,7 +135,6 @@ describe('Starting Integration Test > Sending and Receiving ', function () {
/* expectedDataPayload= */ getTestDataPayload()
);
});

});

it('Foreground app can receive a {} empty message in onMessage', async function () {
Expand Down
2 changes: 1 addition & 1 deletion packages/storage/src/implementation/metadata.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ export function metadataValidator(p: unknown): void {
const val = p[key];
if (key === 'customMetadata') {
if (!type.isObject(val)) {
throw 'Expected object for \'customMetadata\' mapping.';
throw "Expected object for 'customMetadata' mapping.";
}
} else {
if (type.isNonNullObject(val)) {
Expand Down