Skip to content

Patch node-fetch security vulnerability #3769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Patch node-fetch security vulnerability #3769

wants to merge 1 commit into from

Conversation

bradcypert
Copy link

@bradcypert bradcypert commented Sep 11, 2020

There is a known denial of service vulnerability in the node fetch library. This vulnerability was fixed in 2.6.1. Bumping this version should fix this downstream vulnerability.

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

#3768

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

There is a known denial of service vulnerability in the node fetch library. This vulnerability was fixed in 2.6.1. Bumping this version should fix this downstream vulnerability.
@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2020

💥 No Changeset

Latest commit: 58bd0b5

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@bradcypert
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@hsubox76
Copy link
Contributor

Thank you for taking the time to make this PR, I see that the renovate bot has made a PR as well that covers all the cases in the repo (except the functions dep on isomorphic-fetch) and yarn.lock update (#3759), hope you don't mind if I use that one instead.

@hsubox76 hsubox76 closed this Sep 11, 2020
@bradcypert
Copy link
Author

@hsubox76 Not at all! I just was hoping to get the downstream vulnerability fixed in our app. Thanks for all that you do! :D

@bradcypert bradcypert deleted the patch-1 branch September 12, 2020 00:19
@firebase firebase locked and limited conversation to collaborators Oct 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants