Hide converter from Public API #3794
Conversation
The converter property is currently not part of our public API, and as such it should be prefixed with an underscore
💥 No ChangesetLatest commit: ba1e940 Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
Binary Size ReportAffected SDKs
Test Logs
|
Size Analysis ReportAffected ProductsNo changes between base commit (07cbd42) and head commit (b36c9e7). Test Logs
|
| @@ -108,10 +108,10 @@ export class DocumentReference<T = DocumentData> extends _DocumentKeyReference< | |||
|
|
|||
| constructor( | |||
| readonly firestore: FirebaseFirestore, | |||
| readonly converter: FirestoreDataConverter<T> | null, | |||
| _converter: FirestoreDataConverter<T> | null, | |||
There was a problem hiding this comment.
Why does this need to have its readonly property removed? I don't see the converter value being assigned to a new value anywhere.
There was a problem hiding this comment.
The readonly is already part of the parent class, which already uses the underscore naming.
The converter property is currently not part of our public API, and as such it should be prefixed with an underscore
This is firestore-exp/lite only.