Skip to content

Remove 'no-ios' tags from spec tests for limbo resolution throttling #3833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

dconeybe
Copy link
Contributor

Limbo resolution throttling is now implemented in iOS, and, therefore, the spec tests for that feature should be enabled: firebase/firebase-ios-sdk#5310

@dconeybe dconeybe self-assigned this Sep 23, 2020
@changeset-bot
Copy link

changeset-bot bot commented Sep 23, 2020

⚠️ No Changeset found

Latest commit: d71d8a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (e55e7c6) and head commit (66f734d).

Test Logs

@dconeybe dconeybe merged commit cddc551 into master Sep 23, 2020
@dconeybe dconeybe deleted the dconeybe/LimboThrottleSpecTestsEnableIos branch September 23, 2020 18:26
@firebase firebase locked and limited conversation to collaborators Oct 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants