Skip to content

Remove undocumented getLogLevel #3944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 15, 2020
Merged

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Oct 14, 2020

This removes the undocumented Firestore.logLevel API and makes setLogLevel a tree-shakeable function (even in the old SDK).

@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2020

🦋 Changeset detected

Latest commit: c25c30d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
firebase Major
@firebase/firestore Major
@firebase/rules-unit-testing Patch
rxfire Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@schmidt-sebastian schmidt-sebastian changed the title Remove undocument getLogLevel Remove undocumented getLogLevel Oct 14, 2020
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 15, 2020

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (ffef32e) Head (37e3042) Diff
    browser 249 kB 249 kB -353 B (-0.1%)
    esm2017 198 kB 197 kB -233 B (-0.1%)
    main 484 kB 484 kB -407 B (-0.1%)
    module 247 kB 246 kB -300 B (-0.1%)
    react-native 198 kB 197 kB -228 B (-0.1%)
  • @firebase/firestore/memory

    Type Base (ffef32e) Head (37e3042) Diff
    browser 186 kB 186 kB -354 B (-0.2%)
    esm2017 148 kB 147 kB -230 B (-0.2%)
    main 356 kB 356 kB -407 B (-0.1%)
    module 184 kB 184 kB -295 B (-0.2%)
    react-native 148 kB 148 kB -228 B (-0.2%)
  • firebase

    Type Base (ffef32e) Head (37e3042) Diff
    firebase-firestore.js 286 kB 286 kB -311 B (-0.1%)
    firebase-firestore.memory.js 225 kB 225 kB -311 B (-0.1%)
    firebase.js 831 kB 830 kB -317 B (-0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 15, 2020

Size Analysis Report

Affected Products

No changes between base commit (ffef32e) and head commit (37e3042).

Test Logs

Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's see if I have power now.

@schmidt-sebastian schmidt-sebastian merged commit 8939aec into master Oct 15, 2020
@google-oss-bot google-oss-bot mentioned this pull request Oct 22, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/loglevel branch November 9, 2020 22:36
@firebase firebase locked and limited conversation to collaborators Nov 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants