Skip to content

Add changeset formatting check #3980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 28, 2020
Merged

Add changeset formatting check #3980

merged 12 commits into from
Oct 28, 2020

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Oct 22, 2020

Add a yarn changeset status check to the changeset checker, which catches changeset formatting errors. It will still show the "missing packages" warning, and will also show any "yarn changeset status" errors if found, or both, if both are found.

The check will fail if "yarn changeset status" errors are found (blocking merge), but won't fail on "missing packages", it will only print the warning in the comment.

@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2020

⚠️ No Changeset found

Latest commit: deb31fa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2020

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 22, 2020

Binary Size Report

Affected SDKs

No changes between base commit (f4110cc) and head commit (b565799).

Test Logs

@google-oss-bot

This comment has been minimized.

@hsubox76 hsubox76 changed the title WIP: Add changeset formatting check Add changeset formatting check Oct 27, 2020
@Feiyang1 Feiyang1 assigned hsubox76 and unassigned Feiyang1 Oct 28, 2020
@hsubox76 hsubox76 merged commit 878a1bf into master Oct 28, 2020
@firebase firebase locked and limited conversation to collaborators Nov 28, 2020
@hsubox76 hsubox76 deleted the ch-changeset-check branch January 21, 2021 20:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants