use the firebase-exp version for `SDK_VERSION` in app-exp #4027

Feiyang1 · 2020-11-03T00:35:27Z

No description provided.

changeset-bot · 2020-11-03T00:35:30Z

⚠️ No Changeset found

Latest commit: e3d6040

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Feiyang1 · 2020-11-03T00:36:25Z

@avolkovi FYI
@schmidt-sebastian Does Firestore use this value to track usage?

schmidt-sebastian · 2020-11-03T00:50:31Z

@schmidt-sebastian Does Firestore use this value to track usage?

I don't think so. We use our own header: https://osscs.corp.google.com/firebase-sdk/firebase-js-sdk/+/master:packages/firestore/src/remote/rest_connection.ts;l=41

google-oss-bot · 2020-11-03T01:41:48Z

Binary Size Report

Affected SDKs

No changes between base commit (6ef39d4) and head commit (807833e).

Test Logs

Base (6ef39d4d): https://github.com/firebase/firebase-js-sdk/actions/runs/338042944
Head (807833e5): https://github.com/firebase/firebase-js-sdk/actions/runs/342700966

google-oss-bot · 2020-11-03T01:46:19Z

Size Analysis Report

Affected Products

`@firebase/app-exp`

SDK_VERSION

Size

Type Base (6ef39d4) Head (807833e) Diff

size 2.64 kB 2.64 kB +3 B (+0.1%)

size_with_ext_deps 4.06 kB 4.06 kB +3 B (+0.1%)

`@firebase/auth-exp`

ActionCodeURL

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 49.4 kB 49.4 kB +3 B (+0.0%)
AuthCredential

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 48.6 kB 48.6 kB +3 B (+0.0%)
EmailAuthCredential

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 50.4 kB 50.4 kB +3 B (+0.0%)
EmailAuthProvider

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 51.8 kB 51.8 kB +3 B (+0.0%)
FacebookAuthProvider

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 51.7 kB 51.7 kB +3 B (+0.0%)
GithubAuthProvider

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 51.7 kB 51.7 kB +3 B (+0.0%)
GoogleAuthProvider

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 51.8 kB 51.8 kB +3 B (+0.0%)
OAuthCredential

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 50.4 kB 50.4 kB +3 B (+0.0%)
OAuthProvider

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 51.1 kB 51.1 kB +3 B (+0.0%)
PhoneAuthCredential

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 50.4 kB 50.4 kB +3 B (+0.0%)
PhoneAuthProvider

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 52.2 kB 52.2 kB +3 B (+0.0%)
PhoneMultiFactorGenerator

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 49.3 kB 49.3 kB +3 B (+0.0%)
RecaptchaVerifier

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 54.8 kB 54.8 kB +3 B (+0.0%)
TwitterAuthProvider

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 51.7 kB 51.7 kB +3 B (+0.0%)
applyActionCode

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 48.5 kB 48.5 kB +3 B (+0.0%)
browserLocalPersistence

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 51.4 kB 51.4 kB +3 B (+0.0%)
browserPopupRedirectResolver

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 65.6 kB 65.6 kB +3 B (+0.0%)
browserSessionPersistence

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 49.0 kB 49.0 kB +3 B (+0.0%)
checkActionCode

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 49.5 kB 49.5 kB +3 B (+0.0%)
confirmPasswordReset

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 48.5 kB 48.5 kB +3 B (+0.0%)
createUserWithEmailAndPassword

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 49.4 kB 49.4 kB +3 B (+0.0%)
deleteUser

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 48.4 kB 48.4 kB +3 B (+0.0%)
fetchSignInMethodsForEmail

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 48.7 kB 48.7 kB +3 B (+0.0%)
getAdditionalUserInfo

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 49.7 kB 49.7 kB +3 B (+0.0%)
getAuth

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 76.3 kB 76.3 kB +3 B (+0.0%)
getIdToken

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 48.4 kB 48.4 kB +3 B (+0.0%)
getIdTokenResult

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 48.3 kB 48.3 kB +3 B (+0.0%)
getMultiFactorResolver

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 51.2 kB 51.2 kB +3 B (+0.0%)
getRedirectResult

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 54.1 kB 54.1 kB +3 B (+0.0%)
inMemoryPersistence

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 48.3 kB 48.3 kB +3 B (+0.0%)
indexedDBLocalPersistence

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 55.6 kB 55.6 kB +3 B (+0.0%)
initializeAuth

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 49.3 kB 49.3 kB +3 B (+0.0%)
isSignInWithEmailLink

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 49.5 kB 49.5 kB +3 B (+0.0%)
linkWithCredential

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 49.4 kB 49.4 kB +3 B (+0.0%)
linkWithPhoneNumber

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 53.0 kB 53.0 kB +3 B (+0.0%)
linkWithPopup

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 57.1 kB 57.1 kB +3 B (+0.0%)
linkWithRedirect

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 51.9 kB 51.9 kB +3 B (+0.0%)
multiFactor

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 50.5 kB 50.5 kB +3 B (+0.0%)
onAuthStateChanged

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 48.4 kB 48.4 kB +3 B (+0.0%)
onIdTokenChanged

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 48.4 kB 48.4 kB +3 B (+0.0%)
parseActionCodeURL

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 49.4 kB 49.4 kB +3 B (+0.0%)
reauthenticateWithCredential

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 50.0 kB 50.1 kB +3 B (+0.0%)
reauthenticateWithPhoneNumber

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 53.6 kB 53.6 kB +3 B (+0.0%)
reauthenticateWithPopup

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 57.1 kB 57.1 kB +3 B (+0.0%)
reauthenticateWithRedirect

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 51.7 kB 51.7 kB +3 B (+0.0%)
reload

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 48.3 kB 48.3 kB +3 B (+0.0%)
sendEmailVerification

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 49.3 kB 49.3 kB +3 B (+0.0%)
sendPasswordResetEmail

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 49.2 kB 49.2 kB +3 B (+0.0%)
sendSignInLinkToEmail

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 49.3 kB 49.3 kB +3 B (+0.0%)
setPersistence

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 48.4 kB 48.4 kB +3 B (+0.0%)
signInAnonymously

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 49.5 kB 49.5 kB +3 B (+0.0%)
signInWithCredential

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 49.8 kB 49.8 kB +3 B (+0.0%)
signInWithCustomToken

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 49.4 kB 49.4 kB +3 B (+0.0%)
signInWithEmailAndPassword

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 53.3 kB 53.3 kB +3 B (+0.0%)
signInWithEmailLink

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 53.5 kB 53.5 kB +3 B (+0.0%)
signInWithPhoneNumber

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 53.4 kB 53.4 kB +3 B (+0.0%)
signInWithPopup

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 57.1 kB 57.1 kB +3 B (+0.0%)
signInWithRedirect

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 51.4 kB 51.4 kB +3 B (+0.0%)
signOut

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 48.4 kB 48.4 kB +3 B (+0.0%)
unlink

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 49.0 kB 49.0 kB +3 B (+0.0%)
updateCurrentUser

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 48.4 kB 48.4 kB +3 B (+0.0%)
updateEmail

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 48.7 kB 48.7 kB +3 B (+0.0%)
updatePassword

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 48.7 kB 48.7 kB +3 B (+0.0%)
updatePhoneNumber

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 49.1 kB 49.1 kB +3 B (+0.0%)
updateProfile

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 48.9 kB 48.9 kB +3 B (+0.0%)
useDeviceLanguage

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 48.4 kB 48.4 kB +3 B (+0.0%)
verifyBeforeUpdateEmail

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 49.3 kB 49.3 kB +3 B (+0.0%)
verifyPasswordResetCode

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 49.6 kB 49.6 kB +3 B (+0.0%)

`@firebase/remote-config-exp`

activate

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 27.0 kB 27.0 kB +3 B (+0.0%)
ensureInitialized

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 26.7 kB 26.7 kB +3 B (+0.0%)
fetchAndActivate

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 27.6 kB 27.6 kB +3 B (+0.0%)
fetchConfig

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 27.2 kB 27.2 kB +3 B (+0.0%)
getAll

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 27.9 kB 27.9 kB +3 B (+0.0%)
getBoolean

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 27.7 kB 27.7 kB +3 B (+0.0%)
getNumber

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 27.7 kB 27.7 kB +3 B (+0.0%)
getRemoteConfig

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 26.7 kB 26.7 kB +3 B (+0.0%)
getString

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 27.7 kB 27.7 kB +3 B (+0.0%)
getValue

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 27.7 kB 27.7 kB +3 B (+0.0%)
setLogLevel

Size

Type Base (6ef39d4) Head (807833e) Diff

size_with_ext_deps 26.8 kB 26.8 kB +3 B (+0.0%)

Test Logs

Base (6ef39d4d): https://github.com/firebase/firebase-js-sdk/actions/runs/338042944
Head (807833e5): https://github.com/firebase/firebase-js-sdk/actions/runs/342700966

Feiyang1 · 2020-11-03T17:19:54Z

@schmidt-sebastian Do you want to track the exp SDK usage? If so, I think we need to find a way to inject the version number to Firestore.

schmidt-sebastian · 2020-11-03T17:22:36Z

@schmidt-sebastian Do you want to track the exp SDK usage? If so, I think we need to find a way to inject the version number to Firestore.

Yes.

use firebaes-exp version

e3d6040

Feiyang1 requested review from hiranya911 and hsubox76 as code owners November 3, 2020 00:35

Feiyang1 assigned hsubox76 Nov 3, 2020

hsubox76 approved these changes Nov 3, 2020

View reviewed changes

Feiyang1 merged commit f676f67 into master Nov 10, 2020

Feiyang1 deleted the fei-sdk-version-exp branch November 10, 2020 19:29

firebase locked and limited conversation to collaborators Dec 11, 2020

use the firebase-exp version for SDK_VERSION in app-exp #4027

use the firebase-exp version for SDK_VERSION in app-exp #4027

Uh oh!

Conversation

Feiyang1 commented Nov 3, 2020

Uh oh!

changeset-bot bot commented Nov 3, 2020

⚠️ No Changeset found

Uh oh!

Feiyang1 commented Nov 3, 2020

Uh oh!

schmidt-sebastian commented Nov 3, 2020

Uh oh!

google-oss-bot commented Nov 3, 2020

Binary Size Report

Affected SDKs

Test Logs

Uh oh!

google-oss-bot commented Nov 3, 2020

Size Analysis Report

Affected Products

@firebase/app-exp

SDK_VERSION

Size

@firebase/auth-exp

ActionCodeURL

Size

AuthCredential

Size

EmailAuthCredential

Size

EmailAuthProvider

Size

FacebookAuthProvider

Size

GithubAuthProvider

Size

GoogleAuthProvider

Size

OAuthCredential

Size

OAuthProvider

Size

PhoneAuthCredential

Size

PhoneAuthProvider

Size

PhoneMultiFactorGenerator

Size

RecaptchaVerifier

Size

TwitterAuthProvider

Size

applyActionCode

Size

browserLocalPersistence

Size

browserPopupRedirectResolver

Size

browserSessionPersistence

Size

checkActionCode

Size

confirmPasswordReset

Size

createUserWithEmailAndPassword

Size

deleteUser

Size

fetchSignInMethodsForEmail

Size

getAdditionalUserInfo

Size

getAuth

Size

getIdToken

Size

getIdTokenResult

Size

getMultiFactorResolver

use the firebase-exp version for `SDK_VERSION` in app-exp #4027

use the firebase-exp version for `SDK_VERSION` in app-exp #4027

`@firebase/app-exp`

`SDK_VERSION`

`@firebase/auth-exp`

`ActionCodeURL`

`AuthCredential`

`EmailAuthCredential`

`EmailAuthProvider`

`FacebookAuthProvider`

`GithubAuthProvider`

`GoogleAuthProvider`

`OAuthCredential`

`OAuthProvider`

`PhoneAuthCredential`

`PhoneAuthProvider`

`PhoneMultiFactorGenerator`

`RecaptchaVerifier`

`TwitterAuthProvider`

`applyActionCode`

`browserLocalPersistence`

`browserPopupRedirectResolver`

`browserSessionPersistence`

`checkActionCode`

`confirmPasswordReset`

`createUserWithEmailAndPassword`

`deleteUser`

`fetchSignInMethodsForEmail`

`getAdditionalUserInfo`

`getAuth`

`getIdToken`

`getIdTokenResult`

`getMultiFactorResolver`

`getRedirectResult`

`inMemoryPersistence`

`indexedDBLocalPersistence`

`initializeAuth`

`isSignInWithEmailLink`

`linkWithCredential`

`linkWithPhoneNumber`

`linkWithPopup`

`linkWithRedirect`

`multiFactor`

`onAuthStateChanged`

`onIdTokenChanged`

`parseActionCodeURL`

`reauthenticateWithCredential`

`reauthenticateWithPhoneNumber`

`reauthenticateWithPopup`

`reauthenticateWithRedirect`

`reload`

`sendEmailVerification`

`sendPasswordResetEmail`

`sendSignInLinkToEmail`

`setPersistence`

`signInAnonymously`

`signInWithCredential`

`signInWithCustomToken`

`signInWithEmailAndPassword`

`signInWithEmailLink`

`signInWithPhoneNumber`

`signInWithPopup`

`signInWithRedirect`

`signOut`

`unlink`