Add retry logic around logic IndexedDB connections. #4047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Analysis ReportAffected Products
|
| Type | Base (f9dc50e) | Head (669fa16) | Diff |
|---|---|---|---|
| size | 65.0 kB | 65.2 kB | +168 B (+0.3%) |
| size_with_ext_deps | 76.3 kB | 76.5 kB | +168 B (+0.2%) |
Dependencies
| Type | Base (f9dc50e) | Head (669fa16) | Diff |
|---|---|---|---|
| variables | Click to show 41 depsAUTH_ERROR_FACTORYBASE_POPUP_OPTIONSDB_DATA_KEYPATHDB_NAMEDB_OBJECTSTORE_NAMEDB_VERSIONDEFAULT_API_TIMEOUT_MSDEFAULT_HEIGHTDEFAULT_WIDTHEMULATED_IFRAME_PATHEMULATOR_WIDGET_PATHERRORSEVENT_DUPLICATION_CACHE_DURATION_MSFIREFOX_EMPTY_URLHTTP_REGEXIDP_REQUEST_URIIE10_LOCAL_STORAGE_SYNC_DELAYIFRAME_ATTRIBUTESIFRAME_PATHIP_ADDRESS_REGEXNETWORK_TIMEOUTNETWORK_TIMEOUT_DELAYPING_TIMEOUTSERVER_ERROR_MAPSTORAGE_AVAILABLE_KEYTARGET_BLANKWEB_STORAGE_SUPPORT_KEYWIDGET_PATH_POLLING_INTERVAL_MS_POLLING_INTERVAL_MS$1_POLL_WINDOW_CLOSE_TIMEOUTbrowserLocalPersistencebrowserPopupRedirectResolverbrowserSessionPersistencecachedGApiLoaderinMemoryPersistenceindexedDBLocalPersistenceinstanceCachelogClientredirectOutcomeMapversion |
Click to show 42 depsAUTH_ERROR_FACTORYBASE_POPUP_OPTIONSDB_DATA_KEYPATHDB_NAMEDB_OBJECTSTORE_NAMEDB_VERSIONDEFAULT_API_TIMEOUT_MSDEFAULT_HEIGHTDEFAULT_WIDTHEMULATED_IFRAME_PATHEMULATOR_WIDGET_PATHERRORSEVENT_DUPLICATION_CACHE_DURATION_MSFIREFOX_EMPTY_URLHTTP_REGEXIDP_REQUEST_URIIE10_LOCAL_STORAGE_SYNC_DELAYIFRAME_ATTRIBUTESIFRAME_PATHIP_ADDRESS_REGEXNETWORK_TIMEOUTNETWORK_TIMEOUT_DELAYPING_TIMEOUTSERVER_ERROR_MAPSTORAGE_AVAILABLE_KEYTARGET_BLANKWEB_STORAGE_SUPPORT_KEYWIDGET_PATH_POLLING_INTERVAL_MS_POLLING_INTERVAL_MS$1_POLL_WINDOW_CLOSE_TIMEOUT_TRANSACTION_RETRY_COUNTbrowserLocalPersistencebrowserPopupRedirectResolverbrowserSessionPersistencecachedGApiLoaderinMemoryPersistenceindexedDBLocalPersistenceinstanceCachelogClientredirectOutcomeMapversion |
+ _TRANSACTION_RETRY_COUNT |
indexedDBLocalPersistence
Size
| Type | Base (f9dc50e) | Head (669fa16) | Diff |
|---|---|---|---|
| size | 45.1 kB | 45.3 kB | +168 B (+0.4%) |
| size_with_ext_deps | 55.6 kB | 55.8 kB | +168 B (+0.3%) |
Dependencies
| Type | Base (f9dc50e) | Head (669fa16) | Diff |
|---|---|---|---|
| variables | Click to show 19 depsAUTH_ERROR_FACTORYDB_DATA_KEYPATHDB_NAMEDB_OBJECTSTORE_NAMEDB_VERSIONDEFAULT_API_TIMEOUT_MSERRORSNETWORK_TIMEOUTNETWORK_TIMEOUT_DELAYPING_TIMEOUTSERVER_ERROR_MAPSTORAGE_AVAILABLE_KEY_POLLING_INTERVAL_MS$1_POLL_WINDOW_CLOSE_TIMEOUTinMemoryPersistenceindexedDBLocalPersistenceinstanceCachelogClientversion |
Click to show 20 depsAUTH_ERROR_FACTORYDB_DATA_KEYPATHDB_NAMEDB_OBJECTSTORE_NAMEDB_VERSIONDEFAULT_API_TIMEOUT_MSERRORSNETWORK_TIMEOUTNETWORK_TIMEOUT_DELAYPING_TIMEOUTSERVER_ERROR_MAPSTORAGE_AVAILABLE_KEY_POLLING_INTERVAL_MS$1_POLL_WINDOW_CLOSE_TIMEOUT_TRANSACTION_RETRY_COUNTinMemoryPersistenceindexedDBLocalPersistenceinstanceCachelogClientversion |
+ _TRANSACTION_RETRY_COUNT |
Test Logs
- Base (
f9dc50e3): https://github.com/firebase/firebase-js-sdk/actions/runs/348565653 - Head (
669fa16c): https://github.com/firebase/firebase-js-sdk/actions/runs/350050874
sam-gc
reviewed
Nov 6, 2020
packages-exp/auth-exp/src/platform_browser/persistence/indexed_db.ts
Outdated
Show resolved
Hide resolved
sam-gc
reviewed
Nov 6, 2020
| this.db.close(); | ||
| this.db = undefined; | ||
| } | ||
| // TODO: consider adding exponential backoff |
There was a problem hiding this comment.
Is it worth adding any sort of delay here?
There was a problem hiding this comment.
question for @schmidt-sebastian I think he mentioned they had this in Firestore but I couldn't find proof
There was a problem hiding this comment.
We retry immediately at this scope, but at the higher level we retry with backoff: https://github.com/firebase/firebase-js-sdk/blob/master/packages/firestore/src/util/async_queue.ts#L361
There was a problem hiding this comment.
thanks, will consider adding that in a followup if this doesn't fix it
sam-gc
approved these changes
Nov 6, 2020
schmidt-sebastian
approved these changes
Nov 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to https://github.com/firebase/firebase-js-sdk/blob/a10c18f8996fc35942779f5fea5690ae5d102bb0/packages/firestore/src/local/simple_db.ts