Skip to content

FirestoreClient cleanup #4075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2020
Merged

FirestoreClient cleanup #4075

merged 1 commit into from
Nov 24, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

This replaces a bunch of duplicate logic in firestore-exp with the FirestoreClient functions

This replaces a bunch of duplicate logic in firestore-exp with the FirestoreClient functions
@changeset-bot
Copy link

changeset-bot bot commented Nov 16, 2020

⚠️ No Changeset found

Latest commit: 2e25a0f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (6a154eb) and head commit (61c8db0).

Test Logs

@schmidt-sebastian
Copy link
Contributor Author

@var-const Do you have time to look at this next week?

Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Apologies for the delay.

@schmidt-sebastian schmidt-sebastian merged commit c76e1ff into master Nov 24, 2020
@firebase firebase locked and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants