Skip to content

API Extractor Doc fixes #4105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 23, 2020
Merged

API Extractor Doc fixes #4105

merged 2 commits into from
Nov 23, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Nov 20, 2020

API Extractor will be used to generate the reference documentation for firestore-exp. It currently throws some validation errors, and this fixes them by doing the following:

  • Use @returns instead of @return
  • Add "-" for @param
  • HTML escape special characters
  • Fix @link tags
  • Add @hideconstructor for non-public (internal) constructors

I don't think this needs a thorough review, but a spot check would be nice.

- Use  instead of
- Add - for
- HTML escape special charaters
- Fix @link tags
@changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2020

⚠️ No Changeset found

Latest commit: 91db325

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 20, 2020

Size Analysis Report

Affected Products

No changes between base commit (3a19f9e) and head commit (31ea4ae).

Test Logs

@@ -22,7 +22,7 @@ import { PersistencePromise } from './persistence_promise';
/**
* Represents a set of indexes that are used to execute queries efficiently.
*
* Currently the only index is a [collection id] => [parent path] index, used
* Currently the only index is a [collection id] => [parent path] index, used
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to escape it? Does it not work in markdown?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API Extractor complains about all these HTML-like characters (at least with default settings).

Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


/**
* Called by the Firestore SDK to convert a custom model object of type `T`
* into a plain Javascript object (suitable for writing directly to the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ultranit: "Javascript" -> "JavaScript"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@schmidt-sebastian schmidt-sebastian merged commit 80d19e2 into master Nov 23, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/jsdocfixes branch November 23, 2020 20:23
@firebase firebase locked and limited conversation to collaborators Dec 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants