-
Notifications
You must be signed in to change notification settings - Fork 945
API Extractor Doc fixes #4105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Extractor Doc fixes #4105
Conversation
- Use instead of - Add - for - HTML escape special charaters - Fix @link tags
|
Size Analysis ReportAffected ProductsNo changes between base commit (3a19f9e) and head commit (31ea4ae). Test Logs
|
@@ -22,7 +22,7 @@ import { PersistencePromise } from './persistence_promise'; | |||
/** | |||
* Represents a set of indexes that are used to execute queries efficiently. | |||
* | |||
* Currently the only index is a [collection id] => [parent path] index, used | |||
* Currently the only index is a [collection id] => [parent path] index, used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to escape it? Does it not work in markdown?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API Extractor complains about all these HTML-like characters (at least with default settings).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
/** | ||
* Called by the Firestore SDK to convert a custom model object of type `T` | ||
* into a plain Javascript object (suitable for writing directly to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ultranit: "Javascript" -> "JavaScript"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
API Extractor will be used to generate the reference documentation for firestore-exp. It currently throws some validation errors, and this fixes them by doing the following:
@returns
instead of@return
@param
@link
tags@hideconstructor
for non-public (internal) constructorsI don't think this needs a thorough review, but a spot check would be nice.