Add useFirestoreEmulator #4142
Merged
Add useFirestoreEmulator #4142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
Size Analysis ReportAffected ProductsNo changes between base commit (487f8e1) and head commit (769db12). Test Logs
|
samtstern
approved these changes
Dec 1, 2020
| @@ -521,6 +521,9 @@ export function updateDoc(reference: DocumentReference<unknown>, data: UpdateDat | |||
| // @public | |||
| export function updateDoc(reference: DocumentReference<unknown>, field: string | FieldPath, value: unknown, ...moreFieldsAndValues: unknown[]): Promise<void>; | |||
|
|
|||
| // @public | |||
| export function useFirestoreEmulator(firestore: FirebaseFirestore_2, host: string, port: number): void; | |||
There was a problem hiding this comment.
Yeah, it's because we share the code from firestore-lite and firestore-exp. This should go away once #4140 is merged.
| ): void { | ||
| firestore = cast(firestore, FirebaseFirestore); | ||
|
|
||
| if (firestore._getSettings().host !== DEFAULT_HOST) { |
There was a problem hiding this comment.
Out of scope here but I recently realized that this warning shows up if you repeatedly call useEmulator() with the same arguments. If you feel like fixing it, we could check settings.host !== DEFAULT_HOST && settings.host !== host or something.
There was a problem hiding this comment.
Let me fix that.
|
@hsubox76 Friendly ping. |
hsubox76
approved these changes
Jan 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add
useFirestoreEmulatorto firestore-exp.Note: This is tested by the existing
Firestore.useEmulatortests as the invokeuseFirestoreEmulatorindirectly.